-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8314738: Remove all occurrences of and support for @revised #15382
Conversation
👋 Welcome back prappo! A progress list of the required criteria for merging this PR into |
@pavelrappo The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing @revised
tags is not a substantive change, so I wouldn’t update the copyright year as you have in some of these files.
Otherwise, this looks fine.
@pavelrappo This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
I was taught to do it every time when I change a file. Would you like me to revert those changes to copyright years in this case? |
You can leave the copyright years as-is. |
/integrate |
Going to push as commit f39fc0a.
Your commit was automatically rebased without conflicts. |
@pavelrappo Pushed as commit f39fc0a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this simple PR.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15382/head:pull/15382
$ git checkout pull/15382
Update a local copy of the PR:
$ git checkout pull/15382
$ git pull https://git.openjdk.org/jdk.git pull/15382/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15382
View PR using the GUI difftool:
$ git pr show -t 15382
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15382.diff
Webrev
Link to Webrev Comment