Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316003: Update to HTML instructions #15661



Copy link

@aivanov-jdk aivanov-jdk commented Sep 11, 2023

To demonstrate the functionality of HTML formatting in PassFailJFrame, I updated the instructions for the test/jdk/javax/swing/JFileChooser/ test. The commands to create the symbolic links are marked up with monospace font, which makes them stand out. The test instructions for single- and multi-selection are emphasised with bold text.

This change depends on #15660 and JDK-8294158.


  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue


  • JDK-8316003: Update to HTML instructions (Enhancement - P4)



Using git

Checkout this PR locally:
$ git fetch pull/15661/head:pull/15661
$ git checkout pull/15661

Update a local copy of the PR:
$ git checkout pull/15661
$ git pull pull/15661/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15661

View PR using the GUI difftool:
$ git pr show -t 15661

Using diff file

Download this PR as a diff file:


Link to Webrev Comment

Instructions for FileChooserSymLinkTest are rendered in HTML.
Each text component (JTextArea or JEditorPane) are configured
in its own dedicated method. This avoids unnecessary type casts.
It reverts the accidental change where I unwrapped call to createUI
Copy link

bridgekeeper bot commented Sep 11, 2023

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 11, 2023
Copy link

openjdk bot commented Sep 11, 2023

@aivanov-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client label Sep 11, 2023
Copy link

mlbridge bot commented Sep 11, 2023


Copy link

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted that this depends on other PRs

Copy link

bridgekeeper bot commented Oct 18, 2023

@aivanov-jdk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/15660 to master October 25, 2023 11:20
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8316003-html-SymLinkTest
git fetch master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

Copy link

openjdk bot commented Oct 25, 2023

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8316003: Update to HTML instructions

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 25, 2023
Copy link
Member Author


Copy link

openjdk bot commented Oct 25, 2023

Going to push as commit c587211.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 42b9ac8: 8294156: Allow PassFailJFrame.Builder to create test UI

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 25, 2023
@openjdk openjdk bot closed this Oct 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2023
Copy link

openjdk bot commented Oct 25, 2023

@aivanov-jdk Pushed as commit c587211.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk aivanov-jdk deleted the 8316003-html-SymLinkTest branch October 25, 2023 14:06
Copy link
Member Author

/backport jdk21u

Copy link

openjdk bot commented Nov 7, 2023

@aivanov-jdk the backport was successfully created on the branch aivanov-jdk-backport-c587211b in my personal fork of openjdk/jdk21u. To create a pull request with this backport targeting openjdk/jdk21u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit c587211b from the openjdk/jdk repository.

The commit being backported was authored by Alexey Ivanov on 25 Oct 2023 and was reviewed by Phil Race.


If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u:

$ git fetch aivanov-jdk-backport-c587211b:aivanov-jdk-backport-c587211b
$ git checkout aivanov-jdk-backport-c587211b
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push aivanov-jdk-backport-c587211b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
client integrated Pull request has been integrated
2 participants