Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257724: Incorrect package of the linked class in BaseSSLSocketImpl #1605

Closed
wants to merge 1 commit into from

Conversation

XueleiFan
Copy link
Member

@XueleiFan XueleiFan commented Dec 3, 2020

In sun.security.ssl.BaseSSLSocketImpl.java, the package of SocketChannel in the getChannel() spec is java.nio, which is incorrect. It should be java.nio.channels.

Doc cleanup only, no new regression test.

Bug: https://bugs.openjdk.java.net/browse/JDK-8257724


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257724: Incorrect package of the linked class in BaseSSLSocketImpl

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1605/head:pull/1605
$ git checkout pull/1605

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 3, 2020

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 3, 2020
@openjdk
Copy link

openjdk bot commented Dec 3, 2020

@XueleiFan The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Dec 3, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 3, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 4, 2020

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257724: Incorrect package of the linked class in BaseSSLSocketImpl

Reviewed-by: valeriep, wetmore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • d8ac76f: 8257651: LambdaEagerInit.java test failed in 2 different ways
  • 3eb6946: 8257732: Problem list TestJFRWithJMX for OL 8.2 until the issue is resolved
  • ac54900: 8257401: Use switch expressions in jdk.internal.net.http and java.net.http
  • 86b6575: 8257574: C2: "failed: parsing found no loops but there are some" assert failure
  • dede01e: 8257622: MemoryAccess methods are missing @forceinline annotations
  • 1d2d981: 8257423: [PPC64] Support -XX:-UseInlineCaches
  • feabdde: 8251843: jfr/tool/TestPrintJSON.java fails intermittently
  • c6f93ec: 8257707: Fix incorrect format string in Http1HeaderParser
  • fbdc187: 8257624: C2: PhaseMacroExpand::eliminate_macro_nodes() crashes on out-of-bounds access into macro node array
  • fd6756e: 8257634: C2: Introduce IncrementalInliningForceCleanup diagnostic flag
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/85269470e530f820f9190ae799c459c6f65104c6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 4, 2020
@XueleiFan
Copy link
Member Author

XueleiFan commented Dec 4, 2020

/integrate

@openjdk openjdk bot closed this Dec 4, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 4, 2020
@openjdk
Copy link

openjdk bot commented Dec 4, 2020

@XueleiFan Since your change was applied there have been 26 commits pushed to the master branch:

  • d8ac76f: 8257651: LambdaEagerInit.java test failed in 2 different ways
  • 3eb6946: 8257732: Problem list TestJFRWithJMX for OL 8.2 until the issue is resolved
  • ac54900: 8257401: Use switch expressions in jdk.internal.net.http and java.net.http
  • 86b6575: 8257574: C2: "failed: parsing found no loops but there are some" assert failure
  • dede01e: 8257622: MemoryAccess methods are missing @forceinline annotations
  • 1d2d981: 8257423: [PPC64] Support -XX:-UseInlineCaches
  • feabdde: 8251843: jfr/tool/TestPrintJSON.java fails intermittently
  • c6f93ec: 8257707: Fix incorrect format string in Http1HeaderParser
  • fbdc187: 8257624: C2: PhaseMacroExpand::eliminate_macro_nodes() crashes on out-of-bounds access into macro node array
  • fd6756e: 8257634: C2: Introduce IncrementalInliningForceCleanup diagnostic flag
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/85269470e530f820f9190ae799c459c6f65104c6...master

Your commit was automatically rebased without conflicts.

Pushed as commit fcc8479.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@XueleiFan XueleiFan deleted the JDK-8257724 branch Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
3 participants