Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318691: runtime/CompressedOops/CompressedClassPointersEncodingScheme.java fails with release VMs #16330

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Oct 24, 2023

The test fails due to VM option 'CompressedClassSpaceBaseAddress' is develop and is available only in debug version of VM.
So the fix just disables the test for release VMs.

Thanks.
Best regards,
Jie


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318691: runtime/CompressedOops/CompressedClassPointersEncodingScheme.java fails with release VMs (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16330/head:pull/16330
$ git checkout pull/16330

Update a local copy of the PR:
$ git checkout pull/16330
$ git pull https://git.openjdk.org/jdk.git pull/16330/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16330

View PR using the GUI difftool:
$ git pr show -t 16330

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16330.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2023

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 24, 2023
@openjdk
Copy link

openjdk bot commented Oct 24, 2023

@DamonFool The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Oct 24, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 24, 2023

Webrevs

Copy link
Member

@calvinccheung calvinccheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Oct 24, 2023

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318691: runtime/CompressedOops/CompressedClassPointersEncodingScheme.java fails with release VMs

Reviewed-by: ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 24, 2023
@DamonFool
Copy link
Member Author

Looks good.

Thanks @calvinccheung .
Do you think it's trivial?

@calvinccheung
Copy link
Member

Thanks @calvinccheung . Do you think it's trivial?

Yes, it is trivial.

@DamonFool
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 24, 2023

Going to push as commit eb59167.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 24, 2023
@openjdk openjdk bot closed this Oct 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 24, 2023
@openjdk
Copy link

openjdk bot commented Oct 24, 2023

@DamonFool Pushed as commit eb59167.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8318691 branch October 24, 2023 02:59
@tstuefe
Copy link
Member

tstuefe commented Oct 24, 2023

Sorry, and thanks for fixing, @DamonFool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants