-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8320714: java/util/Locale/LocaleProvidersRun.java and java/util/ResourceBundle/modules/visibility/VisibilityTest.java timeout after passing #16831
Conversation
👋 Welcome back jlu! A progress list of the required criteria for merging this PR into |
@justin-curtis-lu The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
@justin-curtis-lu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 69c0b24.
Your commit was automatically rebased without conflicts. |
@justin-curtis-lu Pushed as commit 69c0b24. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this PR which fixes timeouts for the two tests: java/util/Locale/LocaleProvidersRun.java and java/util/ResourceBundle/modules/visibility/VisibilityTest.java.
These tests were updated to accept VM flags in JDK-8319569, which is now causing timeouts in tiers 6 and 8. One set of VM flags causes VisibilityTest.java to timeout with a duration of over 2 hours in tier6.
Both have been updated to run without VM flags and marked as
vm.flagless
.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16831/head:pull/16831
$ git checkout pull/16831
Update a local copy of the PR:
$ git checkout pull/16831
$ git pull https://git.openjdk.org/jdk.git pull/16831/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16831
View PR using the GUI difftool:
$ git pr show -t 16831
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16831.diff
Webrev
Link to Webrev Comment