Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321489: Update LCMS to 2.16 #17382

Closed
wants to merge 2 commits into from
Closed

Conversation

alisenchung
Copy link
Contributor

@alisenchung alisenchung commented Jan 11, 2024

Update LCMS, mach5 client tests are green


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17382/head:pull/17382
$ git checkout pull/17382

Update a local copy of the PR:
$ git checkout pull/17382
$ git pull https://git.openjdk.org/jdk.git pull/17382/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17382

View PR using the GUI difftool:
$ git pr show -t 17382

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17382.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 11, 2024

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 11, 2024
@openjdk
Copy link

openjdk bot commented Jan 11, 2024

@alisenchung The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jan 11, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 11, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 12, 2024

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321489: Update LCMS to 2.16

Reviewed-by: serb, dnguyen, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • 84cf4cb: 8318563: GetClassFields should not use random access to field
  • 9e9c05f: 8322979: Add informative discussion to Modifier
  • c54bca6: 8323617: Add missing null checks to GetMousePositionWithPopup.java test
  • 95a9168: 8323627: Shenandoah: Refactor init logger
  • 999e556: 8312518: [macos13] setFullScreenWindow() shows black screen on macOS 13 & above
  • 8b6293f: 8301994: Remove unused code from awt_List.cpp
  • e33031b: 8323629: Shenandoah: Fix missing include and declaration
  • c5e7245: 8322735: C2: minor improvements of bubble sort used in SuperWord::packset_sort
  • 65a0672: 8319773: Avoid inflating monitors when installing hash codes for LM_LIGHTWEIGHT
  • e22ab10: 8322537: Parallel: Remove experimental adjustment in PSAdaptiveSizePolicy
  • ... and 19 more: https://git.openjdk.org/jdk/compare/c2e77e2f17b624e750dea8fd51bbfde99596690e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 12, 2024
Copy link
Contributor

@DamonGuy DamonGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@alisenchung
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 12, 2024

Going to push as commit dc7d3b1.
Since your change was applied there have been 29 commits pushed to the master branch:

  • 84cf4cb: 8318563: GetClassFields should not use random access to field
  • 9e9c05f: 8322979: Add informative discussion to Modifier
  • c54bca6: 8323617: Add missing null checks to GetMousePositionWithPopup.java test
  • 95a9168: 8323627: Shenandoah: Refactor init logger
  • 999e556: 8312518: [macos13] setFullScreenWindow() shows black screen on macOS 13 & above
  • 8b6293f: 8301994: Remove unused code from awt_List.cpp
  • e33031b: 8323629: Shenandoah: Fix missing include and declaration
  • c5e7245: 8322735: C2: minor improvements of bubble sort used in SuperWord::packset_sort
  • 65a0672: 8319773: Avoid inflating monitors when installing hash codes for LM_LIGHTWEIGHT
  • e22ab10: 8322537: Parallel: Remove experimental adjustment in PSAdaptiveSizePolicy
  • ... and 19 more: https://git.openjdk.org/jdk/compare/c2e77e2f17b624e750dea8fd51bbfde99596690e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 12, 2024
@openjdk openjdk bot closed this Jan 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 12, 2024
@openjdk
Copy link

openjdk bot commented Jan 12, 2024

@alisenchung Pushed as commit dc7d3b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants