8324082: more monitoring test timeout adjustments

[dcubed-ojdk]

Trivial fixes to adjust more monitoring test timeouts.

See the bug report for the gory timeout details.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8324082: more monitoring test timeout adjustments (Bug - P4)

Reviewers

• Kevin Walls (@kevinjwalls - Committer) ⚠️ Review applies to a31a5d19
• Serguei Spitsyn (@sspitsyn - Reviewer) ⚠️ Review applies to a31a5d19

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17478/head:pull/17478
$ git checkout pull/17478

Update a local copy of the PR:
$ git checkout pull/17478
$ git pull https://git.openjdk.org/jdk.git pull/17478/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17478

View PR using the GUI difftool:
$ git pr show -t 17478

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17478.diff

Webrev

Link to Webrev Comment

[dcubed-ojdk]

/label add hotspot-runtime
/label add serviceability

[bridgekeeper]

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dcubed-ojdk
The hotspot-runtime label was successfully added.

[openjdk]

@dcubed-ojdk
The serviceability label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (db7f12f7)
• 00: Full (a31a5d19)

[plummercj]

Shouldn't we use a larger timeoutfactor for slowdebug builds?

[kevinjwalls]

Looks good. Maybe we could be cleverer with different timeout for different builds, but I like the simple update... 8-)

[sspitsyn]

Looks good.

[openjdk]

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324082: more monitoring test timeout adjustments

Reviewed-by: kevinw, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 52f787f: 8323595: is_aligned(p, alignof(OopT))) assertion fails in Jetty without compressed OOPs
• cbfddf4: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination
• 57fad67: 8323667: Library debug files contain non-reproducible full gcc include paths
• ff8cc26: 8323694: RISC-V: Unnecessary ResourceMark in NativeCall::set_destination_mt_safe
• dadd9cd: 8316497: ColorConvertOp - typo for non-ICC conversions needs one-line fix

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dcubed-ojdk]

@plummercj, @kevinjwalls and @sspitsyn - Thanks for the reviews. Copyright years updated.

@plummercj - The collection of adjustments I have been making to the monitoring tests have
all been made with TimeoutFactor == 1. This is intentional because these tests pass with that
timeout factor when they are run by themselves on a system. It is only with extremely high
stress levels that we see these slowdebug timeouts.

/integrate

[openjdk]

Going to push as commit 806ffb1.
Since your change was applied there have been 5 commits pushed to the master branch:

• 52f787f: 8323595: is_aligned(p, alignof(OopT))) assertion fails in Jetty without compressed OOPs
• cbfddf4: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination
• 57fad67: 8323667: Library debug files contain non-reproducible full gcc include paths
• ff8cc26: 8323694: RISC-V: Unnecessary ResourceMark in NativeCall::set_destination_mt_safe
• dadd9cd: 8316497: ColorConvertOp - typo for non-ICC conversions needs one-line fix

Your commit was automatically rebased without conflicts.

[openjdk]

@dcubed-ojdk Pushed as commit 806ffb1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[dcubed-ojdk]

/backport jdk22

[openjdk]

@dcubed-ojdk the backport was successfully created on the branch backport-dcubed-ojdk-806ffb10 in my personal fork of openjdk/jdk22. To create a pull request with this backport targeting openjdk/jdk22:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 806ffb10 from the openjdk/jdk repository.

The commit being backported was authored by Daniel D. Daugherty on 18 Jan 2024 and was reviewed by Kevin Walls and Serguei Spitsyn.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22:

$ git fetch https://github.com/openjdk-bots/jdk22.git backport-dcubed-ojdk-806ffb10:backport-dcubed-ojdk-806ffb10
$ git checkout backport-dcubed-ojdk-806ffb10
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22.git backport-dcubed-ojdk-806ffb10

⚠️ @dcubed-ojdk You are not yet a collaborator in my fork openjdk-bots/jdk22. An invite will be sent out and you need to accept it before you can proceed.

[plummercj]

It is only with extremely high
stress levels that we see these slowdebug timeouts.

I would have considered this as a reason to be using timeoutfactor and not increase the timeouts. Although I don't think what to use as the default timeout for any given test has ever been formalized, certainly the idea is that the test should be expected to pass with the provided timeout (default or specified) on a machine with some given performance expectations (num cores, performance of each core, machine load), and with a jdk build with some given performance expectations (product, fastdebug, slowdebug, -Xcomp, -Xint, etc). Anytime those expectations are not met, timeoutfactor should be used. Your changes imply that the timeout should be good enough for a slowdebug build on a machine with a heavy load. I'm not so sure that makes sense when we have timeoutfactor to deal with such situations. In other words, set one test parameter that will cover all your test runs instead of having to update a large number of tests to make the tests pass on your system. If that is not what timeoutfactor is for, then I don't see why it even exists.