JDK-8325496: Make TrimNativeHeapInterval a product switch #17799

tstuefe · 2024-02-10T09:57:56Z

JDK-8293114 introduced automatic C-heap trimming, for now supported only by the glibc. It is controlled by the command line switch TrimNativeHeapInterval. The feature has proven very valuable to customers, and all issues have been ironed out. So, I'd like to make this switch a non-experimental product switch.

/csr
/label hotspot-runtime

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Change requires CSR request JDK-8325498 to be approved
Commit message must refer to an issue

Issues

JDK-8325496: Make TrimNativeHeapInterval a product switch (Enhancement - P4)
JDK-8325498: Make TrimNativeHeapInterval a product switch (CSR)

Reviewers

David Holmes (@dholmes-ora - Reviewer)
Matthias Baesken (@MBaesken - Reviewer) ⚠️ Review applies to 912df1b2

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17799/head:pull/17799
$ git checkout pull/17799

Update a local copy of the PR:
$ git checkout pull/17799
$ git pull https://git.openjdk.org/jdk.git pull/17799/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17799

View PR using the GUI difftool:
$ git pr show -t 17799

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17799.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-02-10T09:58:27Z

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-02-10T09:59:50Z

@tstuefe has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@tstuefe please create a CSR request for issue JDK-8325498 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

openjdk · 2024-02-10T10:00:12Z

@tstuefe
The hotspot-runtime label was successfully added.

tstuefe · 2024-02-12T09:12:22Z

Ping @dholmes-ora

mlbridge · 2024-02-12T09:17:09Z

Webrevs

dholmes-ora

A few suggestions on the manpage entry. Once finalized I will do the update to the markdown sources for you.

Thanks.

src/java.base/share/man/java.1

tstuefe · 2024-02-16T05:38:21Z

Hi @dholmes-ora, thanks for your review. I massaged in all your feedback.

dholmes-ora

Looks good. Thanks. I will prepare the update for the manpage sources on Monday.

tstuefe · 2024-02-16T07:11:04Z

Thank you @dholmes-ora !

I'll wait then for the CSR to be approved (I think Joe is still awaiting your okay there) and for a second reviewer.

dholmes-ora · 2024-02-18T22:23:48Z

Hi @tstuefe ,
I made the changes to the source markdown and regenerated the troff file and got some minor difference:

 .RE
 .TP
-\f[V]-XX:TrimNativeHeapInterval=\f[R]\f[I]millis\f[R]\f[R]
-Interval, in ms, at which the JVM will trim the native heap. Lower values
-will reclaim memory more eagerly at the cost of higher overhead. A value
-of 0 (default) disables native heap trimming.
+\f[V]-XX:TrimNativeHeapInterval=\f[R]\f[I]millis\f[R]
+Interval, in ms, at which the JVM will trim the native heap.
+Lower values will reclaim memory more eagerly at the cost of higher
+overhead.
+A value of 0 (default) disables native heap trimming.
 Native heap trimming is performed in a dedicated thread.
 .RS
 .PP

Could you adjust your PR accordingly please. Thanks.

…product-switch

tstuefe · 2024-02-19T12:49:49Z

Could you adjust your PR accordingly please. Thanks.

Done. Thank you @dholmes-ora .

dholmes-ora

Thanks. Sorry can you please update the copyright year too:

-.\" Copyright (c) 1994, 2023, Oracle and/or its affiliates. All rights reserved.
+.\" Copyright (c) 1994, 2024, Oracle and/or its affiliates. All rights reserved.

tstuefe · 2024-02-20T08:13:32Z

Thanks. Sorry can you please update the copyright year too:

-.\" Copyright (c) 1994, 2023, Oracle and/or its affiliates. All rights reserved.
+.\" Copyright (c) 1994, 2024, Oracle and/or its affiliates. All rights reserved.

Done. Sorry for forgetting (now that would be a valuable thing to check for jcheck)

dholmes-ora

Sorry the Oracle copyrights need a correction.

dholmes-ora · 2024-02-20T12:02:30Z

test/hotspot/jtreg/gtest/NativeHeapTrimmerGtest.java

@@ -1,6 +1,6 @@
 /*
- * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
- * Copyright (c) 2023 Red Hat, Inc. All rights reserved.
+ * Copyright (c) 2023, 2024 Oracle and/or its affiliates. All rights reserved.


Needs a comma after 2024

dholmes-ora · 2024-02-20T12:02:40Z

test/hotspot/jtreg/runtime/os/TestTrimNative.java

- * Copyright (c) 2023 Red Hat, Inc. All rights reserved.
- * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2023, 2024 Red Hat, Inc. All rights reserved.
+ * Copyright (c) 2023, 2024 Oracle and/or its affiliates. All rights reserved.


Needs a comma after 2024

tstuefe · 2024-02-20T13:20:58Z

Sorry the Oracle copyrights need a correction.

Oh, sorry. Corrected.

openjdk · 2024-02-20T21:50:49Z

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325496: Make TrimNativeHeapInterval a product switch

Reviewed-by: dholmes, mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

27003b5: 8326090: Rename jvmti_aod.h
36246c9: 8326233: Utils#copySSLParameters loses needClientAuth Setting
14f9aba: 8326371: [BACKOUT] Clean up NativeCompilation.gmk and its newly created parts
1bd91cd: 8325963: Clean up NativeCompilation.gmk and its newly created parts
4d50ee6: 8326368: compare.sh -2bins prints ugly errors on Windows
221fbfb: 8320002: Remove obsolete CDS check in Reflection::verify_class_access()
d2590c6: 8325730: StringBuilder.toString allocation for the empty String
aa792ea: 8164094: javadoc allows to create a @link to a non-existent method
a2d027e: 8326089: Text incorrectly placed in breadcrumbs list in generated docs
b419e95: 8294148: Support JSplitPane for instructions and test UI
... and 22 more: https://git.openjdk.org/jdk/compare/b3664927616d898ce099808b34e91cc226c8f8ad...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

dholmes-ora · 2024-02-21T03:13:24Z

test/hotspot/jtreg/gtest/NativeHeapTrimmerGtest.java

- * Copyright (c) 2023, 2024 Oracle and/or its affiliates. All rights reserved.
- * Copyright (c) 2023, 2024 Red Hat, Inc. All rights reserved.
+ * Copyright (c) 2023, 2024, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2023, 2024, Red Hat, Inc. All rights reserved.


Please note the comma remark only applied to Oracle copyright notices. I have no idea what the rules are for Red hat notices.

We seem to be doing this too.

tstuefe · 2024-02-21T04:38:09Z

Thanks a lot @dholmes-ora and @MBaesken !

/integrate

openjdk · 2024-02-21T04:39:10Z

Going to push as commit d31fd78.
Since your change was applied there have been 32 commits pushed to the master branch:

27003b5: 8326090: Rename jvmti_aod.h
36246c9: 8326233: Utils#copySSLParameters loses needClientAuth Setting
14f9aba: 8326371: [BACKOUT] Clean up NativeCompilation.gmk and its newly created parts
1bd91cd: 8325963: Clean up NativeCompilation.gmk and its newly created parts
4d50ee6: 8326368: compare.sh -2bins prints ugly errors on Windows
221fbfb: 8320002: Remove obsolete CDS check in Reflection::verify_class_access()
d2590c6: 8325730: StringBuilder.toString allocation for the empty String
aa792ea: 8164094: javadoc allows to create a @link to a non-existent method
a2d027e: 8326089: Text incorrectly placed in breadcrumbs list in generated docs
b419e95: 8294148: Support JSplitPane for instructions and test UI
... and 22 more: https://git.openjdk.org/jdk/compare/b3664927616d898ce099808b34e91cc226c8f8ad...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-02-21T04:39:15Z

@tstuefe Pushed as commit d31fd78.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

JDK-8325496-Make-TrimNativeHeapInterval-a-product-switch

26795c7

openjdk bot added the csr Pull request needs approved CSR before integration label Feb 10, 2024

openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Feb 10, 2024

Manpage

65ae8b1

tstuefe marked this pull request as ready for review February 12, 2024 09:12

openjdk bot added the rfr Pull request is ready for review label Feb 12, 2024

tstuefe changed the title ~~JDK-8325498: Make TrimNativeHeapInterval a product switch~~ JDK-8325496: Make TrimNativeHeapInterval a product switch Feb 12, 2024

dholmes-ora reviewed Feb 13, 2024

View reviewed changes

src/java.base/share/man/java.1 Outdated Show resolved Hide resolved

src/java.base/share/man/java.1 Outdated Show resolved Hide resolved

src/java.base/share/man/java.1 Outdated Show resolved Hide resolved

Feedback David

15e4527

dholmes-ora approved these changes Feb 16, 2024

View reviewed changes

tstuefe added 2 commits February 19, 2024 13:40

Merge branch 'master' into JDK-8325496-Make-TrimNativeHeapInterval-a-…

be0485d

…product-switch

man change

093536d

dholmes-ora approved these changes Feb 20, 2024

View reviewed changes

tstuefe added 5 commits February 20, 2024 09:11

Update globals.hpp

d641bb2

Update java.1

f28403a

Update NativeHeapTrimmerGtest.java

70dd556

Update TestTrimNative.java

5ea64cc

Update NativeHeapTrimmerGtest.java

912df1b

MBaesken approved these changes Feb 20, 2024

View reviewed changes

ClaudioConsolmagno mentioned this pull request Feb 20, 2024

java: linear solver memory leak google/or-tools#3684

Closed

dholmes-ora reviewed Feb 20, 2024

View reviewed changes

tstuefe added 2 commits February 20, 2024 14:20

Update NativeHeapTrimmerGtest.java

0835db5

Update TestTrimNative.java

116df05

openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Feb 20, 2024

dholmes-ora reviewed Feb 21, 2024

View reviewed changes

dholmes-ora approved these changes Feb 21, 2024

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Feb 21, 2024

openjdk bot closed this Feb 21, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JDK-8325496: Make TrimNativeHeapInterval a product switch #17799

JDK-8325496: Make TrimNativeHeapInterval a product switch #17799

tstuefe commented Feb 10, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Feb 10, 2024

openjdk bot commented Feb 10, 2024

openjdk bot commented Feb 10, 2024

tstuefe commented Feb 12, 2024

mlbridge bot commented Feb 12, 2024 •

edited

Loading

dholmes-ora left a comment

tstuefe commented Feb 16, 2024

dholmes-ora left a comment

tstuefe commented Feb 16, 2024 •

edited

Loading

dholmes-ora commented Feb 18, 2024

tstuefe commented Feb 19, 2024

dholmes-ora left a comment

tstuefe commented Feb 20, 2024

dholmes-ora left a comment

dholmes-ora Feb 20, 2024

dholmes-ora Feb 20, 2024

tstuefe commented Feb 20, 2024

openjdk bot commented Feb 20, 2024 •

edited

Loading

dholmes-ora Feb 21, 2024

tstuefe Feb 21, 2024

tstuefe commented Feb 21, 2024

openjdk bot commented Feb 21, 2024

openjdk bot commented Feb 21, 2024

JDK-8325496: Make TrimNativeHeapInterval a product switch #17799

JDK-8325496: Make TrimNativeHeapInterval a product switch #17799

Conversation

tstuefe commented Feb 10, 2024 • edited by openjdk bot Loading

Progress

Issues

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Feb 10, 2024

openjdk bot commented Feb 10, 2024

openjdk bot commented Feb 10, 2024

tstuefe commented Feb 12, 2024

mlbridge bot commented Feb 12, 2024 • edited Loading

Webrevs

dholmes-ora left a comment

Choose a reason for hiding this comment

tstuefe commented Feb 16, 2024

dholmes-ora left a comment

Choose a reason for hiding this comment

tstuefe commented Feb 16, 2024 • edited Loading

dholmes-ora commented Feb 18, 2024

tstuefe commented Feb 19, 2024

dholmes-ora left a comment

Choose a reason for hiding this comment

tstuefe commented Feb 20, 2024

dholmes-ora left a comment

Choose a reason for hiding this comment

dholmes-ora Feb 20, 2024

Choose a reason for hiding this comment

dholmes-ora Feb 20, 2024

Choose a reason for hiding this comment

tstuefe commented Feb 20, 2024

openjdk bot commented Feb 20, 2024 • edited Loading

dholmes-ora Feb 21, 2024

Choose a reason for hiding this comment

tstuefe Feb 21, 2024

Choose a reason for hiding this comment

tstuefe commented Feb 21, 2024

openjdk bot commented Feb 21, 2024

openjdk bot commented Feb 21, 2024

tstuefe commented Feb 10, 2024 •

edited by openjdk bot

Loading

mlbridge bot commented Feb 12, 2024 •

edited

Loading

tstuefe commented Feb 16, 2024 •

edited

Loading

openjdk bot commented Feb 20, 2024 •

edited

Loading