-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8327645: Serial heap dump should not consume double amount of disk space #18160
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back manc! A progress list of the required criteria for merging this PR into |
82cf803
to
a1b15ec
Compare
@caoman Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
/label add serviceability |
@plummercj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change seems reasonable and avoids some of the extra file overhead in the serial case.
Heap dumper was switched to always use segments by JDK-8299426 / JDK-8321565. |
@alexmenkov Thank you for the quick feedback. I can reproduce the failure with VThreadInHeapDump.java and Do we really need to keep all the HPROF_FRAME and HPROF_TRACE records located together? If not, two possible solutions are:
First approach seems resulting in a more organized heap dump. In any case, we probably only need to do this for serial heap dump. Parallel heap dump could keep using the current approach. |
Right, global writer is used to write HPROF_FRAME/HPROF_TRACE records when unmounted VT is found in the heap. |
❗ This change is not yet ready to be integrated. |
@caoman This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Converted to draft until I have time to address the issue. |
@caoman This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Hi all,
Could anyone review this fix to make serial heap dump only write to a single file?
We highly appreciate the work in https://bugs.openjdk.org/browse/JDK-8306441. However, many of our customers still need to use serial heap dump, as they have limited disk space and need to dump to a network socket.
Tested:
Stress tested with a fastdebug build with tests in
hotspot/jtreg/serviceability/dcmd/gc/HeapDump*
.-Man
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18160/head:pull/18160
$ git checkout pull/18160
Update a local copy of the PR:
$ git checkout pull/18160
$ git pull https://git.openjdk.org/jdk.git pull/18160/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18160
View PR using the GUI difftool:
$ git pr show -t 18160
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18160.diff
Webrev
Link to Webrev Comment