Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258553 Limit number of fields in instance to be considered for scalar replacement #1837

Closed
wants to merge 1 commit into from

Conversation

veresov
Copy link
Contributor

@veresov veresov commented Dec 18, 2020

I stumbled upon a test that we have (gc/TestBigObj.java) that has an object with 64k fields and that is scalar replaceable. Doing so puts a lot of strain on the compiler. I ran a few test and benchmarks and the maximum number of fields in scalar-replaced object that I've seen was 59. I think it should be reasonable to set a limit on the number of fields to 512.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258553: Limit number of fields in instance to be considered for scalar replacement

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1837/head:pull/1837
$ git checkout pull/1837

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 18, 2020

👋 Welcome back iveresov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 18, 2020

@veresov The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Dec 18, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 18, 2020

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 18, 2020

@veresov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258553: Limit number of fields in instance to be considered for scalar replacement

Reviewed-by: kvn, vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • 71ae05d: 8258061: Improve diagnostic information about errors during class redefinition
  • 68f2acb: 8252055: Use java.util.HexFormat in java.security
  • 1dae45d: 8250523: Remove abortOnException diagnostic option from TestHumongousNonArrayAllocation.java
  • 00d80fd: 8258255: Move PtrQueue active flag to SATBMarkQueue
  • 853c047: 8258469: Cleanup remaining safefetch test coding
  • 1e03ca1: 8258471: "search codecache" clhsdb command does not work
  • 3f77a60: 8258582: HttpClient: the HttpClient doesn't explicitly shutdown its default executor when stopping.
  • f15528e: Merge
  • 30ca0a5: 8247994: Localize javadoc search
  • 47c180d: 8258515: javac should issue an error if an annotation is nested in a local class or interface
  • ... and 20 more: https://git.openjdk.java.net/jdk/compare/513269d24e806a1f007dd1c3394f3ca20fbb132d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 18, 2020
Copy link

@iwanowww iwanowww left a comment

Looks good.

@veresov
Copy link
Contributor Author

@veresov veresov commented Dec 18, 2020

/integrate

@openjdk openjdk bot closed this Dec 18, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 18, 2020

@veresov Since your change was applied there have been 35 commits pushed to the master branch:

  • adf0e23: 8257800: CompileCommand TypedMethodOptionMatcher::parse_method_pattern() may over consume
  • 06c24e1: 8256213: Remove os::split_reserved_memory
  • be41468: 8258696: Temporarily revert use of pattern match instanceof until docs-reference is fixed
  • a4f393c: 8258661: Inner class ResponseCacheEntry could be static
  • 3c48819: 8169086: DTLS tests fail intermittently with too much loops or timeout
  • 71ae05d: 8258061: Improve diagnostic information about errors during class redefinition
  • 68f2acb: 8252055: Use java.util.HexFormat in java.security
  • 1dae45d: 8250523: Remove abortOnException diagnostic option from TestHumongousNonArrayAllocation.java
  • 00d80fd: 8258255: Move PtrQueue active flag to SATBMarkQueue
  • 853c047: 8258469: Cleanup remaining safefetch test coding
  • ... and 25 more: https://git.openjdk.java.net/jdk/compare/513269d24e806a1f007dd1c3394f3ca20fbb132d...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7f92d18.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
3 participants