8319997: JFR: Reduce use of dynamic proxies

[egahlin]

Hi,

Could I have a review of a change that removes the use of dynamic proxies for known event metadata, for example labels and descriptions.

Testing: test/jdk/jdk/jfr

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8319997: JFR: Reduce use of dynamic proxies (Enhancement - P3)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19106/head:pull/19106
$ git checkout pull/19106

Update a local copy of the PR:
$ git checkout pull/19106
$ git pull https://git.openjdk.org/jdk.git pull/19106/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19106

View PR using the GUI difftool:
$ git pr show -t 19106

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19106.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319997: JFR: Reduce use of dynamic proxies

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 23a72a1: 8331626: unsafe.cpp:162:38: runtime error in index_oop_from_field_offset_long - applying non-zero offset 4563897424 to null pointer
• a2584a8: 8331714: Make OopMapCache installation lock-free
• df1ff05: 8331085: Crash in MergePrimitiveArrayStores::is_compatible_store()
• 3b8227b: 8326836: Incorrect @since tags for ClassSignature methods
• f308e10: 8331400: AArch64: Sync aarch64_vector.ad with aarch64_vector_ad.m4
• a8b3f19: 8330077: Allow max number of events to be buffered to be configurable to avoid OVERFLOW_EVENT
• ae60d84: 8328501: Incorrect @since tags for java security interfaces
• 7a35f92: 8331660: Parallel: Cleanup includes in parallelScavangeHeap files
• fa02667: 8322726: C2: Unloaded signature class kills argument value

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f886982c)

[egahlin]

/integrate

[openjdk]

Going to push as commit 8d78e8c.
Since your change was applied there have been 14 commits pushed to the master branch:

• 524aaad: 8319957: PhaseOutput::code_size is unused and should be removed
• 95d2f80: 8330016: Stress seed should be initialized for runtime stub compilation
• 5746137: 8331771: ZGC: Remove OopMapCacheAlloc_lock ordering workaround
• 02c95a6: 6968351: httpserver clashes with delayed TCP ACKs for low Content-Length
• 02a799c: 8331695: Serial: DefNewGeneration:_promotion_failed used without being initialized
• 23a72a1: 8331626: unsafe.cpp:162:38: runtime error in index_oop_from_field_offset_long - applying non-zero offset 4563897424 to null pointer
• a2584a8: 8331714: Make OopMapCache installation lock-free
• df1ff05: 8331085: Crash in MergePrimitiveArrayStores::is_compatible_store()
• 3b8227b: 8326836: Incorrect @since tags for ClassSignature methods
• f308e10: 8331400: AArch64: Sync aarch64_vector.ad with aarch64_vector_ad.m4
• ... and 4 more: https://git.openjdk.org/jdk/compare/a8e62af733cb1acc1370561c9dd374b3f9c2c294...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 8d78e8c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.