Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8332084: Ensure JdkConsoleImpl.restoreEcho visibility in a shutdown hook #19184

Closed
wants to merge 12 commits into from
Closed

8332084: Ensure JdkConsoleImpl.restoreEcho visibility in a shutdown hook #19184

Changes from 4 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
43f555e
initial commit
naotoj May 10, 2024
9daf699
Update src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java
naotoj May 13, 2024
3e7d2e0
Replaced another unused exception with _
naotoj May 13, 2024
fb5beb1
Addresses a review comment
naotoj May 13, 2024
898c609
get/setEcho()
naotoj May 14, 2024
e178f0d
Merge branch 'master' into JDK-8332084-restoreEcho-readLock
naotoj May 14, 2024
82d30b3
copyright year
naotoj May 14, 2024
56d95e3
Merge branch 'master' into JDK-8332084-restoreEcho-readLock
naotoj May 16, 2024
e58fbdc
Merge branch 'master' into JDK-8332084-restoreEcho-readLock
naotoj May 20, 2024
f69f747
Used a dedicate lock for restoreEcho
naotoj May 21, 2024
69ec27d
Merge branch 'master' into JDK-8332084-restoreEcho-readLock
naotoj May 24, 2024
d4b6e69
Added comment for restoreEchoLock
naotoj May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ public char[] readPassword(String fmt, Object ... args) {
if (reader instanceof LineReader lr) {
lr.zeroOut();
}
} catch (IOException x) {
} catch (IOException _) {
// ignore
}
throw ioe;
Expand All @@ -152,10 +152,10 @@ public void run() {
if (restoreEcho) {
echo(true);
}
} catch (IOException x) { }
} catch (IOException _) { }
}
});
} catch (IllegalStateException e) {
} catch (IllegalStateException _) {
// shutdown is already in progress and readPassword is first used
// by a shutdown hook
}
Expand Down Expand Up @@ -185,7 +185,7 @@ public Charset charset() {
private final PrintWriter pw;
private final Formatter formatter;
private char[] rcb;
private boolean restoreEcho;
private volatile boolean restoreEcho;
private boolean shutdownHookInstalled;

private char[] readline(boolean zeroOut) throws IOException {
Expand Down