-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8332101: Add an @since
to StandardOperation:REMOVE
in jdk.dynalink
#19189
Conversation
👋 Welcome back nizarbenalla! A progress list of the required criteria for merging this PR into |
@nizarbenalla This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 102 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@nizarbenalla To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
I believe /label core-libs |
@nizarbenalla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me. StandardOperation.REMOVE
was introduced through https://bugs.openjdk.org/browse/JDK-8191905 which was a JDK 10 change, so matches with the proposed change in this PR.
/integrate |
@nizarbenalla |
/sponsor |
Going to push as commit f9f8d0b.
Your commit was automatically rebased without conflicts. |
@jaikiran @nizarbenalla Pushed as commit f9f8d0b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Code cleanup, please review this simple change. I split my changes into 1 PR per module to make reviewing simpler.
To help with the review, this was added back in https://bugs.openjdk.org/browse/JDK-8191905
TIA
Progress
Issue
@<!---->since
toStandardOperation:REMOVE
injdk.dynalink
(Sub-task - P4)Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19189/head:pull/19189
$ git checkout pull/19189
Update a local copy of the PR:
$ git checkout pull/19189
$ git pull https://git.openjdk.org/jdk.git pull/19189/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19189
View PR using the GUI difftool:
$ git pr show -t 19189
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19189.diff
Webrev
Link to Webrev Comment