Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259069: Fields could be final #1936

Closed
wants to merge 1 commit into from

Conversation

XueleiFan
Copy link
Member

@XueleiFan XueleiFan commented Jan 4, 2021

There are a few fields in the SunJSSE provider implementation could be final.

Code clean up to easy the maintenance, no new test.

Bug: https://bugs.openjdk.java.net/browse/JDK-8259069


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1936/head:pull/1936
$ git checkout pull/1936

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2021

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 4, 2021
@openjdk
Copy link

openjdk bot commented Jan 4, 2021

@XueleiFan The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jan 4, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 4, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 4, 2021

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259069: Fields could be final

Reviewed-by: wetmore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • e6f9926: 8257809: JNI warnings from Toolkit JPEG image decoding
  • 9d160aa: 8257815: Replace global log2 functions with efficient implementations
  • f80c63b: 8258490: Shenandoah: Full GC does not need to remark threads and drain SATB buffers
  • 7f04d23: 8258800: Deprecate -XX:+AlwaysLockClassLoader
  • d679caa: 8196466: javax/swing/JFileChooser/8062561/bug8062561.java fails

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 4, 2021
@XueleiFan
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Jan 5, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 5, 2021
@openjdk
Copy link

openjdk bot commented Jan 5, 2021

@XueleiFan Since your change was applied there have been 6 commits pushed to the master branch:

  • f0aae81: 8259020: null-check of g1 write_ref_field_pre_entry is not necessary
  • e6f9926: 8257809: JNI warnings from Toolkit JPEG image decoding
  • 9d160aa: 8257815: Replace global log2 functions with efficient implementations
  • f80c63b: 8258490: Shenandoah: Full GC does not need to remark threads and drain SATB buffers
  • 7f04d23: 8258800: Deprecate -XX:+AlwaysLockClassLoader
  • d679caa: 8196466: javax/swing/JFileChooser/8062561/bug8062561.java fails

Your commit was automatically rebased without conflicts.

Pushed as commit 2499ac3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@XueleiFan XueleiFan deleted the JDK-SUPPRESS branch January 5, 2021 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants