Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253207: enable problemlists jcheck's check #196

Closed
wants to merge 1 commit into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Sep 16, 2020

problemlists[1] check verifies that there are no problem-list entries w/ the bug-id used in the commit message.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/196/head:pull/196
$ git checkout pull/196

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 16, 2020

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@iignatev The following label will be automatically applied to this pull request: build.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Sep 16, 2020
@iignatev
Copy link
Member Author

/label add hotspot

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Sep 16, 2020
@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@iignatev
The hotspot label was successfully added.

@iignatev iignatev marked this pull request as ready for review September 16, 2020 00:22
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 16, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 16, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@iignatev This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253207: enable problemlists jcheck's check

Reviewed-by: erikj
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 46 commits pushed to the master branch:

  • 671dfba: 6714834: JarFile.getManifest() leaves an open InputStream as an undocumented side effect
  • e5866aa: 8244706: GZIP "OS" header flag hard-coded to 0 instead of 255 (RFC 1952 non-compliance)
  • 1086713: 8253206: Enforce whitespace checking for additional source files
  • e2196f8: 8253162: Make frame::oops_do const
  • 300b851: 8253226: Shenandoah: remove unimplemented ShenandoahStrDedupQueue::verify
  • c781594: 8253224: Shenandoah: ShenandoahStrDedupQueue destructor calls virtual num_queues()
  • 33f8e70: 8253173: Print heap before and after GC lacks a newline
  • f509eb0: 8253219: Epsilon: clean up unnecessary includes
  • 7f9b5d9: 8253220: Epsilon: clean up unused code/declarations
  • e0cf023: 8245309: Re-examine use of ThreadLocalCoders in sun.net.www.ParseUtil
  • ... and 36 more: https://git.openjdk.java.net/jdk/compare/5c0d985abf7ef89f9a035692fe9db3ef4001bc2c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 671dfba802bbae9a10182278ee8a1340dcd46472.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 16, 2020
@iignatev
Copy link
Member Author

thanks for your review, Erik.

@iignatev
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Sep 16, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2020
@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@iignatev Since your change was applied there have been 46 commits pushed to the master branch:

  • 671dfba: 6714834: JarFile.getManifest() leaves an open InputStream as an undocumented side effect
  • e5866aa: 8244706: GZIP "OS" header flag hard-coded to 0 instead of 255 (RFC 1952 non-compliance)
  • 1086713: 8253206: Enforce whitespace checking for additional source files
  • e2196f8: 8253162: Make frame::oops_do const
  • 300b851: 8253226: Shenandoah: remove unimplemented ShenandoahStrDedupQueue::verify
  • c781594: 8253224: Shenandoah: ShenandoahStrDedupQueue destructor calls virtual num_queues()
  • 33f8e70: 8253173: Print heap before and after GC lacks a newline
  • f509eb0: 8253219: Epsilon: clean up unnecessary includes
  • 7f9b5d9: 8253220: Epsilon: clean up unused code/declarations
  • e0cf023: 8245309: Re-examine use of ThreadLocalCoders in sun.net.www.ParseUtil
  • ... and 36 more: https://git.openjdk.java.net/jdk/compare/5c0d985abf7ef89f9a035692fe9db3ef4001bc2c...master

Your commit was automatically rebased without conflicts.

Pushed as commit d38c97d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@iignatev iignatev deleted the 8253207 branch September 16, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
2 participants