Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260263: Remove PtrQueue::_qset #2194

Closed

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Jan 22, 2021

Hi all,

can I have reviews for this trivial(?) removal of dead code pertaining to and including PtrQueue::_qset?

Testing: local compilation, tier1

Thanks,
Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2194/head:pull/2194
$ git checkout pull/2194

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 22, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Jan 22, 2021

/summary Remove dead code related to PtrQueue::_qset and itself.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 22, 2021

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Jan 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 22, 2021

@tschatzl Setting summary to Remove dead code related to PtrQueue::_qset and itself.

@tschatzl tschatzl marked this pull request as ready for review Jan 22, 2021
@openjdk openjdk bot added the rfr label Jan 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 22, 2021

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

I hadn't realized the _qset was quite this dead. And this doesn't appear to depend on JDK-8258742 (still waiting for a 2nd reviewer), or even have merge conflicts with it. Cool!

@openjdk
Copy link

@openjdk openjdk bot commented Jan 22, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260263: Remove PtrQueue::_qset

Remove dead code related to PtrQueue::_qset and itself.

Reviewed-by: kbarrett, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 22, 2021
Copy link
Contributor

@kstefanj kstefanj left a comment

Nice cleanup.

@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Jan 25, 2021

Thanks @kimbarrett @kstefanj for your reviews.

/integrate

@openjdk openjdk bot closed this Jan 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 25, 2021

@tschatzl Pushed as commit d825339.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the 8260263-remove-ptrqueue-qset branch Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants