8260263: Remove PtrQueue::_qset

[tschatzl]

Hi all,

can I have reviews for this trivial(?) removal of dead code pertaining to and including PtrQueue::_qset?

Testing: local compilation, tier1

Thanks,
Thomas

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8260263: Remove PtrQueue::_qset

Reviewers

• Kim Barrett (@kimbarrett - Reviewer) ⚠️ Review applies to bdd8568
• Stefan Johansson (@kstefanj - Reviewer) ⚠️ Review applies to bdd8568

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2194/head:pull/2194
$ git checkout pull/2194

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[tschatzl]

/summary Remove dead code related to PtrQueue::_qset and itself.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

@tschatzl Setting summary to Remove dead code related to PtrQueue::_qset and itself.

[mlbridge]

Webrevs

• 01: Full (f90bcf0)
• 00: Full (bdd8568)

[kimbarrett]

I hadn't realized the _qset was quite this dead. And this doesn't appear to depend on JDK-8258742 (still waiting for a 2nd reviewer), or even have merge conflicts with it. Cool!

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260263: Remove PtrQueue::_qset

Remove dead code related to PtrQueue::_qset and itself.

Reviewed-by: kbarrett, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kstefanj]

Nice cleanup.

[tschatzl]

Thanks @kimbarrett @kstefanj for your reviews.

/integrate

[openjdk]

@tschatzl Pushed as commit d825339.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.