8260289: Unable to customize module lists after change JDK-8258411

[andrew-m-leonard]

A problem was found downstream with Eclipse OpenJ9 builds whereby since JDK-8258411 they were unable to extend the module lists.
This PR adds a IncludeCustomExtension to the conf/module-loader-map.conf, to enable the module list extension again.

Signed-off-by: Andrew Leonard anleonar@redhat.com

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8260289: Unable to customize module lists after change JDK-8258411

Reviewers

• Magnus Ihse Bursie (@magicus - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2219/head:pull/2219
$ git checkout pull/2219

[bridgekeeper]

👋 Welcome back aleonard! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@andrew-m-leonard The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (ffd53bf)
• 00: Full (0250fdccf0b86c0505a25a5aa6d16f8ad69c12de)

[andrew-m-leonard]

/test tier1

[openjdk]

@andrew-m-leonard you need to get approval to run the tests in tier1 for commits up until ffd53bf

[andrew-m-leonard]

/help

[openjdk]

@andrew-m-leonard Available commands:

• cc - add or remove an additional classification label
• contributor - adds or removes additional contributors for a PR
• covered - used when employer has signed the OCA
• csr - require a compatibility and specification request (CSR) for this pull request
• help - shows this text
• integrate - performs integration of the changes in the PR
• issue - edit the list of issues that this PR solves
• label - add or remove an additional classification label
• reviewer - manage additional reviewers for a PR
• reviewers - set the number of additional required reviewers for this PR
• signed - used after signing the OCA
• solves - edit the list of issues that this PR solves
• sponsor - performs integration of a PR that is authored by a non-committer
• summary - updates the summary in the commit message
• test - used to run tests

[andrew-m-leonard]

/test builds

[openjdk]

@andrew-m-leonard you need to get approval to run the tests in builds for commits up until ffd53bf

[andrew-m-leonard]

@magicus do you know what the magic pull request command is to re-generate the webrev having updated the commit?

[andrew-m-leonard]

@magicus do you know what the magic pull request command is to re-generate the webrev having updated the commit?

Ah looks like it automatically picked it up :-)

[openjdk]

@andrew-m-leonard This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260289: Unable to customize module lists after change JDK-8258411

Reviewed-by: ihse, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• d076977: 8260169: LogCompilation: Unexpected method mismatch
• 6e03735: 8259845: Move placeholder implementation details to cpp file and add logging
• ca20c63: 8259710: Inlining trace leaks memory
• 09489e2: 8260338: Some fields in HaltNode is not cloned
• af155fc: 8258836: JNI local refs exceed capacity getDiagnosticCommandInfo

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[andrew-m-leonard]

/integrate

[openjdk]

@andrew-m-leonard Since your change was applied there have been 9 commits pushed to the master branch:

• 73c78c8: 8260329: Update references to TAOCP to latest edition
• 5b0b24b: 8260381: ProblemList com/sun/management/DiagnosticCommandMBean/DcmdMBeanTestCheckJni.java on Win with ZGC
• 47c7dc7: 8258833: Cancel multi-part cipher operations in SunPKCS11 after failures
• ef247ab: 8260308: Update LogCompilation junit to 4.13.1
• d076977: 8260169: LogCompilation: Unexpected method mismatch
• 6e03735: 8259845: Move placeholder implementation details to cpp file and add logging
• ca20c63: 8259710: Inlining trace leaks memory
• 09489e2: 8260338: Some fields in HaltNode is not cloned
• af155fc: 8258836: JNI local refs exceed capacity getDiagnosticCommandInfo

Your commit was automatically rebased without conflicts.

Pushed as commit 12ccd21.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.