Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260674: ProblemList jdk/incubator/vector/VectorHash.java in Xcomp configs #2321

Closed
wants to merge 1 commit into from

Conversation

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jan 29, 2021

A trivial fix to ProblemList jdk/incubator/vector/VectorHash.java in Xcomp configs.
I'm trying to reduce the noise in the CI.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260674: ProblemList jdk/incubator/vector/VectorHash.java in Xcomp configs

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2321/head:pull/2321
$ git checkout pull/2321

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jan 29, 2021

/label hotspot-compiler
/label hotspot-runtime

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 29, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Jan 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 29, 2021

@dcubed-ojdk
The hotspot-compiler label was successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 29, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 29, 2021

Webrevs

Copy link

@iwanowww iwanowww left a comment

Looks good and trivial

@openjdk
Copy link

@openjdk openjdk bot commented Jan 29, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260674: ProblemList jdk/incubator/vector/VectorHash.java in Xcomp configs

Reviewed-by: vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 29, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jan 29, 2021

@iwanowww - Thanks for the fast review!

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jan 30, 2021

/integrate

@openjdk openjdk bot closed this Jan 30, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 30, 2021

@dcubed-ojdk Since your change was applied there has been 1 commit pushed to the master branch:

  • 71bfe96: 8217633: Configurable extensions with system properties

Your commit was automatically rebased without conflicts.

Pushed as commit fb46c91.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the dcubed-ojdk:JDK-8260674 branch Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants