8260959: remove RECORDS from PreviewFeature.Feature enum

[vicente-romero-oracle]

Please review this simple fix that is removing the RECORDS enum constant from the PreviewFeature.Feature enum, now that RECORDS are final in 16 this constant can be safely removed.

Thanks,
Vicente

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8260959: remove RECORDS from PreviewFeature.Feature enum

Reviewers

• Jan Lahoda (@lahodaj - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2360/head:pull/2360
$ git checkout pull/2360

[bridgekeeper]

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vicente-romero-oracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c392cf2)

[vicente-romero-oracle]

/label remove core-libs

[openjdk]

@vicente-romero-oracle
The core-libs label was successfully removed.

[vicente-romero-oracle]

/label add compiler

[openjdk]

@vicente-romero-oracle
The compiler label was successfully added.

[jonathan-gibbons]

Given the scary comment and reference to JDK 15 and boot cycle builds, is it really safe to remove the constant?

[jddarcy]

So currently, JDK 17 can be built with a boot JDK of 15, 16, or 17 (since JDK-8257459: "Bump minimum boot jdk to JDK 16") hasn't been fixed yet.

JDK 17 can currently be used as boot JDK only for itself, right? And in the future be used for JDK 18, and 19.

[vicente-romero-oracle]

we already did a very similar fix for text blocks, so this patch is just doing the same for RECORDS

[lahodaj]

I think that, in this specific case, we can remove the constant. The reason is that the PreviewFeature has been moved to a different package recently, so the JDK 15/16 versions of the API use the original PreviewFeature class, and should not produce any warnings. The builds look OK as well.

[openjdk]

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260959: remove RECORDS from PreviewFeature.Feature enum

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

• c1dea39: 8260335: [macos] Running app using relative path causes problems
• f7a6cff: 8261149: Initial nroff manpage update for JDK 17
• be772ff: 8261023: Document why memory pretouch must be a store
• 83357b1: 8261030: Avoid loading GenerateJLIClassesHelper at runtime
• 992b500: 8261036: Reduce classes loaded by CleanerFactory initialization
• e8ad8b3: 8259956: jdk.jfr.internal.ChunkInputStream#available should return the sum of remaining available bytes
• 06b33a0: 8261107: ArrayIndexOutOfBoundsException in the ICC_Profile.getInstance(InputStream)
• 60f440d: 6436374: Graphics.setColor(null) is not documented
• 82028e7: 8260012: Reduce inclusion of collectedHeap.hpp and heapInspection.hpp
• 9b7a8f1: Merge
• ... and 50 more: https://git.openjdk.java.net/jdk/compare/55d62a53380a0583397dacd4bd1b12f0c6be46bf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bridgekeeper]

@vicente-romero-oracle This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[vicente-romero-oracle]

/integrate

[openjdk]

@vicente-romero-oracle Since your change was applied there have been 583 commits pushed to the master branch:

• 05fe06a: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux
• 422eba8: 8263536: Add @build tags to jpackage tests
• 0d2f87e: 8263562: Checking if proxy_klass_head is still lambda_proxy_is_available
• a67a679: 8263679: C1: Remove vtable call
• 11c8c78: 8248904: Add support to jpackage for the Mac App Store
• dc93138: 8256732: Zero: broken +ZeroTLAB exposes badly initialized memory
• e33bfb3: 8263450: Simplify LambdaForm.useCount
• 75ef6f5: 8263427: Shenandoah: Trigger weak-LRB even when heap is stable
• 4517d72: 8263612: Unused variables in C1 runtime
• 83a9a02: 8263509: LdapSchemaParser.readNextTag checks array length incorrectly
• ... and 573 more: https://git.openjdk.java.net/jdk/compare/55d62a53380a0583397dacd4bd1b12f0c6be46bf...master

Your commit was automatically rebased without conflicts.

Pushed as commit 9cb9af6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.