Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261109: [macOS] Remove disabled warning for JNF in make/autoconf/flags-cflags.m4 #2396

Closed
wants to merge 2 commits into from

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented Feb 4, 2021

remove un-needed disabling now JNF has gone ..


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261109: [macOS] Remove disabled warning for JNF in make/autoconf/flags-cflags.m4

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2396/head:pull/2396
$ git checkout pull/2396

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 4, 2021

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 4, 2021

@prrace The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Feb 4, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 4, 2021

Webrevs

mrserb
mrserb approved these changes Feb 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 4, 2021

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261109: [macOS] Remove disabled warning for JNF in make/autoconf/flags-cflags.m4

Reviewed-by: serb, ihse, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 4, 2021
magicus
magicus approved these changes Feb 4, 2021
@openjdk openjdk bot added the core-libs label Feb 4, 2021
@prrace
Copy link
Contributor Author

@prrace prrace commented Feb 4, 2021

Magnus pointed out a condition that I think should have been removed in the fix for
8257858 : Remove JNF dependency from libosxsecurity/KeystoreImpl.m

since its a build related change too, and I've verified that after removing it we still build, I am rolling it in here, if that's OK with folks

erikj79
erikj79 approved these changes Feb 4, 2021
Copy link
Member

@erikj79 erikj79 left a comment

Looks good to me.

@prrace
Copy link
Contributor Author

@prrace prrace commented Feb 4, 2021

/integrate

@openjdk openjdk bot closed this Feb 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 4, 2021

@prrace Since your change was applied there have been 25 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 3bb6a3d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prrace prrace deleted the warn branch Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants