Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8241463: Move build tools to respective modules #2475

Closed
wants to merge 1 commit into from

Conversation

magicus
Copy link
Member

@magicus magicus commented Feb 9, 2021

This is a re-post of a change that was posted as webrev prior to the Github migration. It is not ready for integration as-is, since it needs to be rebased to the current HEAD, and that is bound to be a non-trivial operation after this much time.

However, I think it is relevant to have this available as a Github review, in light of the closely related JDK-8257733.

This patch will move the source code for the build tools into their respective modules, in a separate tools directory.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2475/head:pull/2475
$ git checkout pull/2475

@magicus
Copy link
Member Author

magicus commented Feb 9, 2021

/label build

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 9, 2021

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 9, 2021

@magicus this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout shuffle-build-tools
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added merge-conflict Pull request has merge conflict with target branch build build-dev@openjdk.org labels Feb 9, 2021
@openjdk
Copy link

openjdk bot commented Feb 9, 2021

@magicus
The build label was successfully added.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 21, 2021

@magicus This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented May 19, 2021

@magicus This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org merge-conflict Pull request has merge conflict with target branch
1 participant