8261431: SA: Add comments about load address of executable

[YaSuenag]

I removed the comment about load address of executable in JDK-8248876 (#2366), but it contained useful information for maintenance.

So I re-add them, and add comment for the change in JDK-8248876. Please see #2366 (comment)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8261431: SA: Add comments about load address of executable

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Kevin Walls (@kevinjwalls - Committer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2478/head:pull/2478
$ git checkout pull/2478

[bridgekeeper]

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@YaSuenag The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d6fad55)

[sspitsyn]

Hi Yasumasa,
LGTM
Thanks,
Serguei

[openjdk]

@YaSuenag This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261431: SA: Add comments about load address of executable

Reviewed-by: sspitsyn, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• a3d6e37: 8261302: NMT: Improve malloc site table hashing
• ad54d8d: 8260934: java/lang/StringBuilder/HugeCapacity.java fails without Compact Strings
• 752f92b: 6211242: AreaAveragingScaleFilter(int, int): IAE is not specified
• 3af334a: 6211257: BasicStroke.createStrokedShape(Shape): NPE is not specified
• 4619f37: 8261472: BasicConstraintsExtension::toString shows "PathLen:2147483647" if there is no pathLenConstraint
• 699a3cd: 8223188: Removed unnecessary #ifdef __cplusplus from .cpp sources
• 05c6009: 8259656: fixpath.sh changes broke _NT_SYMBOL_PATH in RunTests.gmk
• ef7ee3f: 8225081: Remove Telia Company CA certificate expiring in April 2021
• 7c565f8: 8261209: isStandalone property: remove dependency on pretty-print
• 01d9280: 8261299: Use-after-free on failure path in LinuxPackage.c, getJvmLauncherLibPath
• ... and 10 more: https://git.openjdk.java.net/jdk/compare/8ebed28403afa1fae2505a1937694c90d27c6d6b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kevinjwalls]

Thanks!

[YaSuenag]

Thanks @sspitsyn !
@kevinjwalls Can you approve this change?

[YaSuenag]

Thanks @kevinjwalls !

[YaSuenag]

/integrate

[openjdk]

@YaSuenag Since your change was applied there have been 38 commits pushed to the master branch:

• 4a72cea: 8261509: Move per-thread StackWatermark from Thread to JavaThread class
• eef86a8: 8261029: Code heap page sizes not traced correctly using os::trace_page_sizes
• 0a89987: 8240281: Remove failing assertion code when selecting first memory state in SuperWord::co_locate_pack
• 9fed604: 8261300: jpackage: rewrite while(0)/while(false) to proper blocks
• 8b6ab31: 8261418: Reduce decoder creation overheads for sun.nio.cs.ext Charsets
• 5e1b809: 8261444: Remove unused fields in Lower
• a9c3680: 8261250: Dependencies: Remove unused dependency types
• 3ede231: 8259430: C2: assert(in_vt->length() == out_vt->length()) failed: mismatch on number of elements
• 1662373: 8235139: Deprecate the socket impl factory mechanism
• 49cf13d: 8261449: Micro-optimize JVM_LatestUserDefinedLoader
• ... and 28 more: https://git.openjdk.java.net/jdk/compare/8ebed28403afa1fae2505a1937694c90d27c6d6b...master

Your commit was automatically rebased without conflicts.

Pushed as commit c342323.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.