-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8261473: Shenandoah: Add breakpoint support #2489
Conversation
👋 Welcome back zgu! A progress list of the required criteria for merging this PR into |
@zhengyu123 this pull request can not be integrated into git checkout JDK-8261473-breakpoint
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
@zhengyu123 The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, minor nits.
#include "utilities/events.hpp" | ||
|
||
// Breakpoint support | ||
class ShenandoahBreakpointScope : public StackObj { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably be ShenandoahBreakpointGCScope
to match that other "MarkScope".
/integrate |
@zhengyu123 This PR has not yet been marked as ready for integration. |
@zhengyu123 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 105 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@zhengyu123 Since your change was applied there have been 105 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 9cf4f90. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this patch that adds breakpoint support for Shenandoah, that allows Shenandoah to access a few tests:
gc/TestConcurrentGCBreakpoints.java
gc/TestJNIWeak/TestJNIWeak.java
gc/TestReferenceClearDuringMarking.java
gc/TestReferenceClearDuringReferenceProcessing.java
gc/TestReferenceRefersTo.java
The drawback is that above tests can not run with passive mode, which can result tests to hang, as breakpoints only apply to concurrent GC.
Test:
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2489/head:pull/2489
$ git checkout pull/2489