-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8261660: AArch64: Race condition in stub code generation for LSE Atomics #2553
Conversation
👋 Welcome back aph! A progress list of the required criteria for merging this PR into |
@theRealAph |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay, but I have to wonder if the rest of the template changes
in src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp
that were made by https://bugs.openjdk.java.net/browse/JDK-8261027
also need to be backed out? Please clarify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this will be fine for now until the code generation and update of the code pointers can be corrected to happen in the right order.
@theRealAph This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation. Thumbs up.
This is a trivial fix and does not have to wait for 24 hours.
@dcubed-ojdk A complete fix merely requires writing the generated stub code before updating the stub function pointers. With this change all that happens is that those pointers continue pointing to the default routines. There is no point backing out the rest of the code given that it will almost all be needed. |
/integrate |
@theRealAph Since your change was applied there have been 4 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit a305743. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Temporary fix for race condition.
There's a narrow race condition in the code which generates LSE Atomic stubs and enables them for use by the runtime. DIsable LSE stub generation for now.
/cc hotspot
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2553/head:pull/2553
$ git checkout pull/2553