New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8261636: The test mapping in hugetlbfs_sanity_check should consider LargePageSizeInBytes #2695
Conversation
…argePageSizeInBytes
👋 Welcome back sjohanss! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the exact same code to add these bits is now three times in that file, it may be interesting to add and use a (static?) method?
Added helper for adding the large page size flag when needed.
Good point, that makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A cpp file local static method would have been fine with me too, but this is as good.
@kstefanj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 64 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Then I would have had to pass the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Thanks Thomas and Ivan for the reviews :) |
/integrate |
@kstefanj Since your change was applied there have been 64 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 0a7fff4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
When explicit large pages are enabled we do a sanity check to test if there are large pages configured. This sanity check just tests if there are any pages available of the systems default large page size. When the flag
LargePageSizeInBytes
is specified the JVM will try to use this large page size for all its mapping, except for the first sanity mapping. This can lead to large pages being disabled because the sanity mapping failed, while there are still plenty of pages available of the size specified byLargePageSizeInBytes
.The fix is to simply take the large page size into consideration in the sanity-check, making sure the correct flags are passed when needed.
Testing
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2695/head:pull/2695
$ git checkout pull/2695