8256417: Exclude TestJFRWithJMX test from running with PodMan

[mseledts]

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8256417: Exclude TestJFRWithJMX test from running with PodMan

Reviewers

• Igor Ignatyev (@iignatev - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2726/head:pull/2726
$ git checkout pull/2726

[bridgekeeper]

👋 Welcome back mseledtsov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mseledts The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mseledts]

Please review this small change that excludes the TestJFRWithJMX test from execution on Podman.
In summary, this test requires capabilities that are not available under "rootless" podman.
What was done:

• added an at-requires method to return the name of the container engine
• using the above named at requires to exclude this test as described above

[mlbridge]

Webrevs

• 02: Full - Incremental (5c2e3cb)
• 01: Full - Incremental (3e5364a)
• 00: Full (43d6c16)

[mseledts]

@hseigel @iignatev Could you please take a look?

[iignatev]

Hi Misha,

so this test can't be run w/ podman only if the test-user doesn't have root-level privileges? if so, I think it's better to check if we really don't have such priviliges and throw SkippedException (e.g. the same way we do in SATestUtils via Platform.isRoot). that way, the test will still be runnable in some configurations.

-- Igor

[mseledts]

Igor, thanks for the suggestion. I will update the code to use SkippedException and Platform.isRoot

[mseledts]

Igor, while following your suggestion of using jtreg.SkippedException, I am thinking about keeping the new VMProps.containerEngine() in the VMProps.java. It can come in handy in the future. I hope you do not mind that.

[mseledts]

I have updated the changes. @iignatev please review.

[iignatev]

Igor, while following your suggestion of using jtreg.SkippedException, I am thinking about keeping the new VMProps.containerEngine() in the VMProps.java. It can come in handy in the future. I hope you do not mind that.

generally speaking, I am no fan of adding things we don't use. instead, I'd suggest you creating Platform::containerEngine (or better Container::engine) and it in the test. and if/when the needs for @requiers container.engine appears, we can add one w/ almost zero effort.

PS you need to update copyright year in all the updated files.

-- Igor

[mseledts]

OK, I will just remove the code from VMProps.

[openjdk]

@mseledts This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256417: Exclude TestJFRWithJMX test from running with PodMan

Reviewed-by: iignatyev

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• 722142e: 8261520: JDK-8261302 breaks runtime/NMT/CheckForProperDetailStackTrace.java
• bcca100: 4710675: JTextArea.setComponentOrientation does not work with correct timing
• fce5765: 8262433: doclint: reference error in module jdk.incubator.foreign
• 059ede0: 8262428: doclint warnings in java.xml module
• 8256517: 8262421: doclint warnings in jdk.compiler module
• 29c603f: 8262227: Change SystemDictionary::find() to return an InstanceKlass*.
• 35c0a69: 8262416: ProblemList TestHeapDumpForLargeArray.java due to JDK-8262386
• 228c285: 8261170: Upgrade to freetype 2.10.4
• ded96dd: 8139348: Deprecate 3DES and RC4 in Kerberos
• 5a9b701: 8258444: Clean up specifications of java.io.Reader.read(char[],int,int) in subclass overrides
• ... and 12 more: https://git.openjdk.java.net/jdk/compare/65492129a906e200fae3aef2d965d590c22a0290...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mseledts]

Thank you Igor.
/integrate

[openjdk]

@mseledts Since your change was applied there have been 33 commits pushed to the master branch:

• c9e9189: 8262074: Consolidate the default value of MetaspaceSize
• 05c11bc: 8262426: Change TRAPS to Thread* for find_constrained_instance_or_array_klass()
• d06d6f5: 8262402: Make CATCH macro assert not fatal
• 47a0842: 8241403: JavaThread::get_thread_name() should be ThreadSMR-aware
• 3088e1e: 8262430: doclint warnings in java.base module
• 67b9e5a: 8262420: typo: @implnote in java.desktop module
• 240f2a1: 8260366: ExtendedSocketOptions can deadlock in some circumstances
• de3f519: 8258897: wrong translation of capturing local classes inside nested lambdas
• d7efb4c: 8262199: issue in jli args.c
• 7603278: 8260198: TypeInstPtr::dump2() emits multiple lines if Verbose is set
• ... and 23 more: https://git.openjdk.java.net/jdk/compare/65492129a906e200fae3aef2d965d590c22a0290...master

Your commit was automatically rebased without conflicts.

Pushed as commit 07061fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.