New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8261812: C2 compilation fails with assert(!had_error) failed: bad dominance #2774
Closed
Closed
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108 changes: 108 additions & 0 deletions
108
test/hotspot/jtreg/compiler/escapeAnalysis/TestValAtSafepointOverflowsInt.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,108 @@ | ||
/* | ||
* Copyright (c) 2021, Red Hat, Inc. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
/** | ||
* @test | ||
* @bug 8261812 | ||
* @summary C2 compilation fails with assert(!had_error) failed: bad dominance | ||
* | ||
* @run main/othervm -XX:-BackgroundCompilation TestValAtSafepointOverflowsInt | ||
* | ||
*/ | ||
|
||
public class TestValAtSafepointOverflowsInt { | ||
private static volatile int volatileField; | ||
|
||
public static void main(String[] args) { | ||
for (int i = 0; i < 20_000; i++) { | ||
testByte(true, false); | ||
testByte(false, false); | ||
testShort(true, false); | ||
testShort(false, false); | ||
testChar(true, false); | ||
testChar(false, false); | ||
} | ||
testByte(true, true); | ||
testShort(true, true); | ||
testChar(true, true); | ||
} | ||
|
||
private static Object testByte(boolean flag, boolean flag2) { | ||
int i; | ||
// loop to delay constant folding | ||
for (i = 0; i < 9; i++) { | ||
} | ||
C obj = new C(); | ||
if (flag) { | ||
obj.byteField = (byte)(1 << i); | ||
} else { | ||
obj.byteField = (byte)(1 << (i+1)); | ||
} | ||
// Phi for byte here for uncommon trap in never taken path below | ||
// Phi inputs don't fit in a byte. Phi transfomed to top. | ||
if (flag2) { | ||
return obj; | ||
} | ||
return null; | ||
} | ||
|
||
private static Object testShort(boolean flag, boolean flag2) { | ||
int i; | ||
for (i = 0; i < 17; i++) { | ||
} | ||
C obj = new C(); | ||
if (flag) { | ||
obj.shortField = (short)(1 << i); | ||
} else { | ||
obj.shortField = (short)(1 << (i+1)); | ||
} | ||
if (flag2) { | ||
return obj; | ||
} | ||
return null; | ||
} | ||
|
||
private static Object testChar(boolean flag, boolean flag2) { | ||
int i; | ||
for (i = 0; i < 17; i++) { | ||
} | ||
C obj = new C(); | ||
if (flag) { | ||
obj.charField = (char)(1 << i); | ||
} else { | ||
obj.charField = (char)(1 << (i+1)); | ||
} | ||
if (flag2) { | ||
return obj; | ||
} | ||
return null; | ||
} | ||
|
||
|
||
static class C { | ||
byte byteField; | ||
short shortField; | ||
char charField; | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some excess whitespacing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed. Thanks for the review.