New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8261785: Calling "main" method in anonymous nested class crashes the JVM #2999
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
/* | ||
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
import java.io.IOException; | ||
|
||
public class CrashTheJVM { | ||
public static void main(String... args) throws IOException { | ||
System.out.println("Fine 1: from the outer class"); | ||
|
||
new Object() { | ||
public static void main(String... args) throws IOException { | ||
System.out.println("Crash Before Fix 1: from anonymous nested class"); | ||
} | ||
}; | ||
class LocalNestedClass { | ||
public static void main(String... args) throws IOException { | ||
System.out.println("Crash Before Fix 2: from local nested class"); | ||
} | ||
} | ||
} | ||
|
||
public void fromMethod() { | ||
new Object() { | ||
public static void main(String... args) throws IOException { | ||
System.out.println("Crash Before Fix 3: from local anonymous class"); | ||
} | ||
}; | ||
class LocalInnerClass { | ||
public static void main(String... args) throws IOException { | ||
System.out.println("Crash Before Fix 4: from local inner class"); | ||
} | ||
} | ||
} | ||
|
||
public class InnerClass { | ||
public static void main(String... args) throws IOException { | ||
System.out.println("Fine 2: from inner class"); | ||
} | ||
} | ||
|
||
public static class NestedClass { | ||
public static void main(String... args) throws IOException { | ||
System.out.println("Fine 3: from nested class"); | ||
} | ||
} | ||
|
||
Object foo = new Object() { | ||
public static void main(String... args) throws IOException { | ||
System.out.println("Anonymous inner class"); | ||
} | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
/* | ||
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
import java.io.IOException; | ||
import java.nio.file.Files; | ||
import java.nio.file.Path; | ||
import java.nio.file.Paths; | ||
import org.testng.annotations.Test; | ||
import static org.testng.Assert.assertEquals; | ||
import static org.testng.Assert.assertTrue; | ||
|
||
/* | ||
* @test | ||
* @bug 8261785 | ||
* @summary Test static main methods in anonymous/local class won't cause launcher crash | ||
* @modules jdk.compiler jdk.zipfs | ||
* @compile ../TestHelper.java | ||
* @run testng Test8261785 | ||
*/ | ||
public class Test8261785 { | ||
private final Path inputDir; | ||
|
||
public Test8261785() { | ||
inputDir = Paths.get(System.getProperty("test.src", ".")); | ||
} | ||
|
||
public void compile() { | ||
Path file = inputDir.resolve("CrashTheJVM.java"); | ||
TestHelper.compile("-d", ".", file.toAbsolutePath().toString()); | ||
} | ||
|
||
@Test | ||
public void run() throws IOException { | ||
System.out.println("Current folder: " + Paths.get(".").toAbsolutePath().toString()); | ||
compile(); | ||
String[] clz = Files.list(Paths.get(".")) | ||
.peek(p -> System.out.println("Found " + p.toString())) | ||
.map(Path::getFileName) | ||
.map(Path::toString) | ||
.filter(f -> f.endsWith(".class")) | ||
.map(f -> f.substring(0, f.length() - 6)) | ||
.toArray(String[]::new); | ||
assertEquals(clz.length, 8); | ||
for (String f: clz) { | ||
System.out.println("Running class " + f); | ||
var result = TestHelper.doExec(TestHelper.javaCmd, "-cp", ".", f); | ||
assertTrue(result.isOK()); | ||
}; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is mostly based on the bug report as I just adjust static keyword to make sure we cover different cases, thus I am not sure whether to add copyright or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to clarify this, if we cannot add copyright here, we should not use this file.