8264002: Delete outdated assumptions about ColorSpace initialization #3140
Conversation
|
|
| && !cs.equals(ColorSpace.getInstance(ColorSpace.CS_LINEAR_RGB)) | ||
| && !cs.equals(ColorSpace.getInstance(ColorSpace.CS_GRAY)) | ||
| && !cs.equals(ColorSpace.getInstance(ColorSpace.CS_CIEXYZ)) | ||
| && !cs.equals(ColorSpace.getInstance(ColorSpace.CS_PYCC)); | ||
| } |
There was a problem hiding this comment.
The method above was added by the tiff implementation in jdk9 and it is mostly a copy of the older code in the jpeg plugin. I merged two methods and leave it here in the "common" code.
| /* These are kept in the inner class to avoid static initialization | ||
| * of the CMM class until someone actually needs it. | ||
| * (e.g. do not init CMM on the request for jpeg mime types) | ||
| */ |
There was a problem hiding this comment.
It is not necessary to delay the usage of ColorSpace, it itself defers the usage of cmm.
|
@mrserb This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 57 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
|
/integrate |
|
@mrserb Since your change was applied there have been 60 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit cfc9aa3. |
Some codes have outdated assumptions about the initialization of ColorSpace class.
Progress
Issue
Reviewers
Download
To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3140/head:pull/3140$ git checkout pull/3140To update a local copy of the PR:
$ git checkout pull/3140$ git pull https://git.openjdk.java.net/jdk pull/3140/headThe text was updated successfully, but these errors were encountered: