Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8257774: G1: Trigger collect when free region count drops below threshold to prevent evacuation failures #3143

Closed
wants to merge 15 commits into from
Closed

8257774: G1: Trigger collect when free region count drops below threshold to prevent evacuation failures #3143

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
fe61d04
Improve G1GC accounting for humongous objects
Nov 5, 2020
56056d7
Address feedback and make other changes.
adityamandaleeka Mar 5, 2021
5889ff8
Further refactoring/changes.
adityamandaleeka Mar 23, 2021
eff81a2
Fix whitespace and comment.
adityamandaleeka Mar 23, 2021
d4e02ed
Fix a few warnings as well as a Windows build error.
adityamandaleeka Mar 25, 2021
42f3d7d
Fix format specifiers.
adityamandaleeka Mar 25, 2021
4ec80ab
Refactor allocation funcs, removing attempt_lock_free_first.
adityamandaleeka Apr 22, 2021
66fa097
Remove temp init variable, update code after rebase.
adityamandaleeka Apr 22, 2021
80df203
Remove temp comment.
adityamandaleeka Apr 29, 2021
57421e1
Minor updates/feedback.
adityamandaleeka May 17, 2021
d6ea382
Minor indentation/formatting improvements.
adityamandaleeka May 25, 2021
6325a72
Add G1 configuration option for proactive collections.
adityamandaleeka May 25, 2021
a2b0b67
Make ProactiveGC JVM flag a diagnostic option.
adityamandaleeka May 26, 2021
817e9bb
Rename proactive to preventive.
adityamandaleeka May 29, 2021
6e11e5b
Revert test change and instead disable preventive GC for evac failure…
adityamandaleeka Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 8 additions & 5 deletions test/hotspot/jtreg/gc/g1/TestGCLogMessages.java
View file
Open in desktop
Expand Up @@ -250,6 +250,8 @@ private void testWithEvacuationFailureLogs() throws Exception {
"-XX:+G1EvacuationFailureALot",
"-XX:G1EvacuationFailureALotCount=100",
"-XX:G1EvacuationFailureALotInterval=1",
"-XX:+UnlockDiagnosticVMOptions",
"-XX:-G1AllowPreventiveGC",
"-Xlog:gc+phases=debug",
GCTestWithEvacuationFailure.class.getName());

Expand All @@ -261,6 +263,8 @@ private void testWithEvacuationFailureLogs() throws Exception {
"-Xmx32M",
"-Xmn16M",
"-Xms32M",
"-XX:+UnlockDiagnosticVMOptions",
"-XX:-G1AllowPreventiveGC",
"-Xlog:gc+phases=trace",
GCTestWithEvacuationFailure.class.getName());

Expand Down Expand Up @@ -314,17 +318,16 @@ public static void main(String [] args) {
static class GCTestWithEvacuationFailure {
private static byte[] garbage;
private static byte[] largeObject;
private static Object[] holder = new Object[800]; // Must be larger than G1EvacuationFailureALotCount
private static Object[] holder = new Object[200]; // Must be larger than G1EvacuationFailureALotCount

public static void main(String [] args) {
largeObject = new byte[16*1024*1024];
System.out.println("Creating garbage");
// Create 64 MB of garbage. This should result in at least one GC,
// Create 16 MB of garbage. This should result in at least one GC,
// (Heap size is 32M, we use 17MB for the large object above)
// which is larger than G1EvacuationFailureALotInterval and enough
// will survive to cause the evacuation failure.
// which is larger than G1EvacuationFailureALotInterval.
for (int i = 0; i < 16 * 1024; i++) {
holder[i % holder.length] = new byte[4096];
holder[i % holder.length] = new byte[1024];
}
System.out.println("Done");
}
Expand Down