Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264173: [s390] Improve Hardware Feature Detection And Reporting #3196

Closed
wants to merge 3 commits into from

Conversation

@RealLucy
Copy link

@RealLucy RealLucy commented Mar 25, 2021

This enhancement is intended to improve the hardware feature detection and reporting, in particular for more recently introduced hardware. The enhancement is a prerequisite for possible future feature exploitation.

Reviews are highly welcome and appreciated.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264173: [s390] Improve Hardware Feature Detection And Reporting

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3196/head:pull/3196
$ git checkout pull/3196

Update a local copy of the PR:
$ git checkout pull/3196
$ git pull https://git.openjdk.java.net/jdk pull/3196/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3196

View PR using the GUI difftool:
$ git pr show -t 3196

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3196.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 25, 2021

👋 Welcome back lucy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 25, 2021

@RealLucy The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Mar 25, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 25, 2021

Webrevs

@RealLucy
Copy link
Author

@RealLucy RealLucy commented Mar 25, 2021

/cc hotspot-compiler

@openjdk
Copy link

@openjdk openjdk bot commented Mar 25, 2021

@RealLucy
The hotspot-compiler label was successfully added.

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

I didn't expect the change to become that large. But it looks good to me. The lengthy output only gets generated with -XX:+Verbose. That's fine.

"system-z, g7-z13, ldisp_fast, extimm, pcrel_load/store, cmpb, cond_load/store, interlocked_update, txm, vectorinstr",
"system-z, g8-z14, ldisp_fast, extimm, pcrel_load/store, cmpb, cond_load/store, interlocked_update, txm, vectorinstr, instrext2, venh1)",
"system-z, g9-z15, ldisp_fast, extimm, pcrel_load/store, cmpb, cond_load/store, interlocked_update, txm, vectorinstr, instrext2, venh1, instrext3, VEnh2 )"
};

This comment has been minimized.

@TheRealMDoerr

TheRealMDoerr Mar 29, 2021
Contributor

Would be nice to generate the feature string from a table it instead of having so many copies. But I'm ok with it for now.

if (Verbose) {
print_features();
if (Verbose || PrintAssembly || PrintStubCode) {
print_features_internal("CPU Version as detected internally: ", PrintAssembly || PrintStubCode);

This comment has been minimized.

@TheRealMDoerr

TheRealMDoerr Mar 29, 2021
Contributor

2 spaces while other usages have no spaces?

This comment has been minimized.

@RealLucy

RealLucy Mar 29, 2021
Author

You are right. These spaces were excessive. Now they are gone.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 29, 2021

@RealLucy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264173: [s390] Improve Hardware Feature Detection And Reporting

Reviewed-by: mdoerr, goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 161 new commits pushed to the master branch:

  • 9d65039: 8263984: Invalidate printServices when there are no printers
  • adb860e: 8255800: Raster creation methods need some specification clean up
  • eab8455: 8261137: Optimization of Box nodes in uncommon_trap
  • 92fad1b: 8264680: Use the blessed modifier order in java.desktop
  • 17202c8: 8264748: Do not include arguments.hpp from compilerDefinitions.hpp
  • c3abdc9: 8264797: Do not include klassVtable.hpp from instanceKlass.hpp
  • eb5c097: 8262389: Use permitted_enctypes if default_tkt_enctypes or default_tgs_enctypes is not present
  • bfb034a: 8264524: jdk/internal/platform/docker/TestDockerMemoryMetrics.java fails due to swapping not working
  • a756d8d: 8264759: x86_32 Minimal VM build failure after JDK-8262355
  • 0f13e22: 8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive"
  • ... and 151 more: https://git.openjdk.java.net/jdk/compare/f69afba52735008613f0ede7d650372e95e9a6e0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 29, 2021
@RealLucy
Copy link
Author

@RealLucy RealLucy commented Mar 29, 2021

Thank you for the review, Martin!

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 7, 2021

LGTM

@GoeLin
GoeLin approved these changes Apr 7, 2021
@RealLucy
Copy link
Author

@RealLucy RealLucy commented Apr 7, 2021

Thank you Goetz!
I will now proceed and integrate the PR.

@RealLucy
Copy link
Author

@RealLucy RealLucy commented Apr 7, 2021

/integrate

@openjdk openjdk bot closed this Apr 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2021

@RealLucy Since your change was applied there have been 161 commits pushed to the master branch:

  • 9d65039: 8263984: Invalidate printServices when there are no printers
  • adb860e: 8255800: Raster creation methods need some specification clean up
  • eab8455: 8261137: Optimization of Box nodes in uncommon_trap
  • 92fad1b: 8264680: Use the blessed modifier order in java.desktop
  • 17202c8: 8264748: Do not include arguments.hpp from compilerDefinitions.hpp
  • c3abdc9: 8264797: Do not include klassVtable.hpp from instanceKlass.hpp
  • eb5c097: 8262389: Use permitted_enctypes if default_tkt_enctypes or default_tgs_enctypes is not present
  • bfb034a: 8264524: jdk/internal/platform/docker/TestDockerMemoryMetrics.java fails due to swapping not working
  • a756d8d: 8264759: x86_32 Minimal VM build failure after JDK-8262355
  • 0f13e22: 8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive"
  • ... and 151 more: https://git.openjdk.java.net/jdk/compare/f69afba52735008613f0ede7d650372e95e9a6e0...master

Your commit was automatically rebased without conflicts.

Pushed as commit d3fdd73.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealLucy RealLucy deleted the RealLucy:JDK-8264173 branch Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants