8264795: IGV: Upgrade NetBeans platform #3361

robcasloz · 2021-04-06T18:34:54Z

This change upgrades the NetBeans platform on which IGV is based to its latest version (12.3) and switches IGV's build system from Ant to Maven. The upgrade introduces support for a wide range of JDK versions (from 8 to 15, the latest version supported by NetBeans 12.3), and the switch from Ant to Maven makes the IGV build simpler, faster (first-time build is approximately 5x faster), and more stable (all dependencies are fetched directly from the Maven central repository).

The change also fixes broken unit tests in the Data module and runs them by default when building.

Testing

Regression-tested the following use cases manually on all combinations of (Linux, Windows, macOS) and (JDK 8, JDK 11, JDK 15):

build
open graph file (small.xml in test-input.zip)
import graphs via network (localhost)
expand groups in outline
open a graph
open a clone
zoom in and out
search a node
apply filters
extract a node
show all nodes
select nodes corresponding to a bytecode
view control flow
select nodes corresponding to a basic block
cluster nodes
show satellite view
compute the difference of two graphs
change node text
remove a group
save groups into a file
open a large graph file (large.xml in test-input.zip)
open a large graph ("After Escape Analysis" in large.xml)

Thanks to Vladimir Ivanov for helping with testing on macOS.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8264795: IGV: Upgrade NetBeans platform

Reviewers

Vladimir Kozlov (@vnkozlov - Reviewer) ⚠️ Review applies to 11fb43f
Christian Hagedorn (@chhagedorn - Reviewer)
Nils Eliasson (@neliasso - Reviewer) ⚠️ Review applies to 11fb43f
Xin Liu (@navyxliu - no project role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3361/head:pull/3361
$ git checkout pull/3361

Update a local copy of the PR:
$ git checkout pull/3361
$ git pull https://git.openjdk.java.net/jdk pull/3361/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3361

View PR using the GUI difftool:
$ git pr show -t 3361

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3361.diff

…ith the previous model

openjdk · 2021-04-06T18:47:52Z

@robcasloz
The build label was successfully removed.

mlbridge · 2021-04-06T19:17:35Z

Webrevs

01: Full - Incremental (e84d171e)
00: Full (11fb43fa)

vnkozlov

Great work!
After this is pushed consider to update wiki page too: https://wiki.openjdk.java.net/display/HotSpot/IdealGraphVisualizer

openjdk · 2021-04-06T20:03:34Z

@robcasloz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264795: IGV: Upgrade NetBeans platform

Upgrade IGV's underlying NetBeans platform to version 12.3, switch build system
from Ant to Maven, and fix broken unit tests in Data module.

Reviewed-by: kvn, chagedorn, neliasso, xliu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 136 new commits pushed to the master branch:

f2f7aa3: 8262291: Refactor reserve_memory_special_huge_tlbfs
008fc75: 8264224: Add macosx-aarch64 to Oracle build configurations
f4e6395: 8264190: Harden TLS interop tests
18bec9c: 8265084: [BACKOUT] 8264954: unified handling for VectorMask object re-materialization during de-optimization
9dd9625: 8263763: Synthetic constructor parameters of enum are not considered for annotation indices
1ee80e0: 8261355: No data buffering in SunPKCS11 Cipher encryption when the underlying mechanism has no padding
d84a7e5: 8264124: Update MXBean specification and implementation to extend mapping of CompositeType to records
714ae54: 8258788: incorrect response to change in window insets [lanai]
f479437: 8265082: test/hotspot/jtreg/gc/g1/TestG1SkipCompaction.java fails validate-source
27f4b27: 8264623: Change to Xcode 12.4 for building on Macos at Oracle
... and 126 more: https://git.openjdk.java.net/jdk/compare/011f6d13ab306581f595d6743ca0ff6dfbf95932...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

robcasloz · 2021-04-07T07:36:23Z

Great work!
After this is pushed consider to update wiki page too: https://wiki.openjdk.java.net/display/HotSpot/IdealGraphVisualizer

Thanks for reviewing, Vladimir! Yes, I plan to do that.

chhagedorn

Very nice work!

src/utils/IdealGraphVisualizer/README.md

...s/IdealGraphVisualizer/Data/src/main/java/com/sun/hotspot/igv/data/serialization/Parser.java

neliasso

I have tested IGV on a High-DPI screen (4K). The screens are attached to the bug-report.

Compared to baseline the new version improved DPI scaling on both JDK8 and JDK15. Some elements still doesn't scale.

Remaining issues identified:

The default zoom level is to small
The filter view has broken scaling - the font scales but not the line height.
The buttons above the graph view and file list doesn't scale - they are still tiny.
The splash screen doesn't scale

Still this is a big improvement and the remaining issues can be solved in separate PRs.

Looks good - Reviewed!

robcasloz · 2021-04-07T11:53:46Z

Very nice work!

Thanks for reviewing, Christian!

robcasloz · 2021-04-07T11:57:51Z

I have tested IGV on a High-DPI screen (4K). The screens are attached to the bug-report.

Compared to baseline the new version improved DPI scaling on both JDK8 and JDK15. Some elements still doesn't scale.

Remaining issues identified:
1. The default zoom level is to small

2. The filter view has broken scaling - the font scales but not the line height.

3. The buttons above the graph view and file list doesn't scale - they are still tiny.

4. The splash screen doesn't scale
Still this is a big improvement and the remaining issues can be solved in separate PRs.

Looks good - Reviewed!

Thanks for reviewing, Nils! I will create a separate RFE for DPI scaling issues.

I also added a clarification to the README file (e84d171) based on our offline discussion.

navyxliu

Thank you for modernizing IGV. I manage to import this project to IntelliJ. The process is hassle-free!

I also ran using jdk8/jdk11 on macOS. I haven't identified any problem so far.

src/utils/IdealGraphVisualizer/Filter/pom.xml

y1yang0 · 2021-04-11T05:12:09Z

Nice work. It works on Windows home pc. 🚀

robcasloz · 2021-04-12T09:00:07Z

Thank you for modernizing IGV. I manage to import this project to IntelliJ. The process is hassle-free!

I also ran using jdk8/jdk11 on macOS. I haven't identified any problem so far.

Thanks for checking, Xin!

robcasloz · 2021-04-12T09:07:11Z

Nice work. It works on Windows home pc. rocket

Thanks for checking, Yang!

robcasloz · 2021-04-13T09:24:44Z

/summary
Upgrade IGV's underlying NetBeans platform to version 12.3, switch build system
from Ant to Maven, and fix broken unit tests in Data module.

openjdk · 2021-04-13T09:25:32Z

@robcasloz Setting summary to:

Upgrade IGV's underlying NetBeans platform to version 12.3, switch build system
from Ant to Maven, and fix broken unit tests in Data module.

robcasloz · 2021-04-13T09:26:51Z

/integrate

openjdk · 2021-04-13T09:28:11Z

@robcasloz Since your change was applied there have been 136 commits pushed to the master branch:

f2f7aa3: 8262291: Refactor reserve_memory_special_huge_tlbfs
008fc75: 8264224: Add macosx-aarch64 to Oracle build configurations
f4e6395: 8264190: Harden TLS interop tests
18bec9c: 8265084: [BACKOUT] 8264954: unified handling for VectorMask object re-materialization during de-optimization
9dd9625: 8263763: Synthetic constructor parameters of enum are not considered for annotation indices
1ee80e0: 8261355: No data buffering in SunPKCS11 Cipher encryption when the underlying mechanism has no padding
d84a7e5: 8264124: Update MXBean specification and implementation to extend mapping of CompositeType to records
714ae54: 8258788: incorrect response to change in window insets [lanai]
f479437: 8265082: test/hotspot/jtreg/gc/g1/TestG1SkipCompaction.java fails validate-source
27f4b27: 8264623: Change to Xcode 12.4 for building on Macos at Oracle
... and 126 more: https://git.openjdk.java.net/jdk/compare/011f6d13ab306581f595d6743ca0ff6dfbf95932...master

Your commit was automatically rebased without conflicts.

Pushed as commit 954b9a1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

robcasloz added 30 commits April 1, 2021 13:50

Add initial Maven application (start from RELEASE90)

580c4c9

Add initial modules (Data and Settings)

14e6b77

Use same group id across all modules

782f699

Add Util module

c2c75f5

Add Layout module

7fe13da

Add Difference module

a05278c

Add NetworkConnection module

87366f2

Add Coordinator module

eee9979

Add SelectionCoordinator module

03e76db

Add Graph module

20e0733

Add HierarchicalLayout module

e1604b9

Add ControlFlow module

88a4818

Add Filter module

b8918a5

Add Bytecodes module

7b4dac0

Add ServerCompiler module

d75ebaa

Add FilterWindow module

03ba1f2

Add Graal module

0446617

Add BatikSVGProxy and View modules

a2499ee

Add missing resource to Data module

992d75d

Add missing resources to Bytecodes module

1d6a8a4

Update Settings manifest EOL format for consistency

d37641a

Move declaration of public packages to each module, for consistency w…

036911a

…ith the previous model

Declare key service providers with annotations

f43d3d1

Update directory structure of branding module

4119dcc

Define NetBeans version only once

46f75f7

Use project version property when possible

ecdab04

Use consistent version of Swing Layout Extensions

4c589fb

Use single definition of Maven plugin versions

fd8d631

Upgrade to NetBeans platform 10.0

316f29f

Upgrade to NetBeans platform 12.3

3c240e9

openjdk bot removed the build build-dev@openjdk.org label Apr 6, 2021

robcasloz marked this pull request as ready for review April 6, 2021 19:00

openjdk bot added the rfr Pull request is ready for review label Apr 6, 2021

vnkozlov approved these changes Apr 6, 2021

View changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 6, 2021

chhagedorn approved these changes Apr 7, 2021

View changes

src/utils/IdealGraphVisualizer/README.md Outdated Show resolved Hide resolved

...s/IdealGraphVisualizer/Data/src/main/java/com/sun/hotspot/igv/data/serialization/Parser.java Outdated Show resolved Hide resolved

neliasso approved these changes Apr 7, 2021

View changes

robcasloz added 3 commits April 7, 2021 13:30

Document latest JDK version supported

e50ccd9

Use lambdas to define runnables

ea19b4d

Document how to build and run on a specific JDK

e84d171

chhagedorn approved these changes Apr 7, 2021

View changes

navyxliu approved these changes Apr 9, 2021

View changes

src/utils/IdealGraphVisualizer/Filter/pom.xml Show resolved Hide resolved

robcasloz mentioned this pull request Apr 12, 2021

8263790: C2: new igv_print_immediately() for debugging purpose #3071

Closed

3 tasks

openjdk bot closed this Apr 13, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 13, 2021

8264795: IGV: Upgrade NetBeans platform #3361

8264795: IGV: Upgrade NetBeans platform #3361

robcasloz commented Apr 6, 2021 •

edited by openjdk bot

openjdk bot commented Apr 6, 2021

mlbridge bot commented Apr 6, 2021 •

edited

vnkozlov left a comment

openjdk bot commented Apr 6, 2021 •

edited

robcasloz commented Apr 7, 2021

chhagedorn left a comment

neliasso left a comment

robcasloz commented Apr 7, 2021

robcasloz commented Apr 7, 2021

navyxliu left a comment

y1yang0 commented Apr 11, 2021 •

edited

robcasloz commented Apr 12, 2021

robcasloz commented Apr 12, 2021

robcasloz commented Apr 13, 2021

openjdk bot commented Apr 13, 2021

robcasloz commented Apr 13, 2021

openjdk bot commented Apr 13, 2021

8264795: IGV: Upgrade NetBeans platform #3361

8264795: IGV: Upgrade NetBeans platform #3361

Conversation

robcasloz commented Apr 6, 2021 • edited by openjdk bot

Testing

Progress

Issue

Reviewers

Reviewing

openjdk bot commented Apr 6, 2021

mlbridge bot commented Apr 6, 2021 • edited

Webrevs

vnkozlov left a comment

Choose a reason for hiding this comment

openjdk bot commented Apr 6, 2021 • edited

robcasloz commented Apr 7, 2021

chhagedorn left a comment

Choose a reason for hiding this comment

neliasso left a comment

Choose a reason for hiding this comment

robcasloz commented Apr 7, 2021

robcasloz commented Apr 7, 2021

navyxliu left a comment

Choose a reason for hiding this comment

y1yang0 commented Apr 11, 2021 • edited

robcasloz commented Apr 12, 2021

robcasloz commented Apr 12, 2021

robcasloz commented Apr 13, 2021

openjdk bot commented Apr 13, 2021

robcasloz commented Apr 13, 2021

openjdk bot commented Apr 13, 2021

robcasloz commented Apr 6, 2021 •

edited by openjdk bot

mlbridge bot commented Apr 6, 2021 •

edited

openjdk bot commented Apr 6, 2021 •

edited

y1yang0 commented Apr 11, 2021 •

edited