Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264983: Add gtest for JDK-8264008 #3414

Closed
wants to merge 2 commits into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Apr 9, 2021

Hi all,

Here is the gtest for JDK-8264008 as discussed here: #3142 (review) .
Any comments?

Testing:

  • test/hotspot/jtreg/gtest/MetaspaceUtilsGtests.java on Linux/{x64,x86_32} and macOSX

Thanks.
Best regards,
Jie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3414/head:pull/3414
$ git checkout pull/3414

Update a local copy of the PR:
$ git checkout pull/3414
$ git pull https://git.openjdk.java.net/jdk pull/3414/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3414

View PR using the GUI difftool:
$ git pr show -t 3414

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3414.diff

@DamonFool
Copy link
Member Author

/test
/label add hotspot-runtime
/cc hotspot-runtime

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 9, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Apr 9, 2021
@openjdk
Copy link

openjdk bot commented Apr 9, 2021

@DamonFool
The hotspot-runtime label was successfully added.

@openjdk
Copy link

openjdk bot commented Apr 9, 2021

@DamonFool The hotspot-runtime label was already applied.

@mlbridge
Copy link

mlbridge bot commented Apr 9, 2021

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Sorry for the long delay.

..Thomas

@@ -73,3 +73,18 @@ TEST_VM(MetaspaceUtils, committed_compressed_class_pointers) {
EXPECT_LE(committed_class, committed);
}

TEST_VM(MetaspaceUtils, none_compressed_class_pointers) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"non_compressed"

@openjdk
Copy link

openjdk bot commented Apr 20, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264983: Add gtest for JDK-8264008

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 162 new commits pushed to the master branch:

  • 072ae7e: 8265436: G1: Improve gc+phases log output during full gc
  • d81b046: 8263227: C2: inconsistent spilling due to dead nodes in exception block
  • a25bae8: 8261445: Use memory_order_relaxed for os::random().
  • 5136643: 8262725: IGV: crash when removing all graphs in a group
  • 79798c6: 8265136: ZGC: Expose GarbageCollectorMXBeans for both pauses and cycles
  • f1d4ae6: 8263718: unused-result warning happens at os_linux.cpp
  • 787908c: 8264221: Rewrite confusing stream API chain in SnippetMaps
  • 142edd3: 8265152: jpackage cleanup fails on Windows with IOException deleting msi
  • ab22407: 8265486: ProblemList javax/sound/midi/Sequencer/Recording.java on macosx-aarch64
  • e0fd5fc: 8265028: JDWP debug agent thread lookup can be made faster
  • ... and 152 more: https://git.openjdk.java.net/jdk/compare/b3782ead36022ecc3ee2375f0f2be15ca4bbeec6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 20, 2021
@DamonFool
Copy link
Member Author

Looks good. Sorry for the long delay.

..Thomas

Thanks @tstuefe for your review.

@DamonFool
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Apr 20, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 20, 2021
@openjdk
Copy link

openjdk bot commented Apr 20, 2021

@DamonFool Since your change was applied there have been 180 commits pushed to the master branch:

  • 91b08b7: 8261779: JCK test api/javax_crypto/EncryptedPrivateKeyInfo/Ctor4.html is failing with assertion error when assertions enabled
  • 2fcd920: 8261183: Follow on to Make lists of normal filenames
  • 40ef00c: 8258457: testlibrary_tests/ctw/JarDirTest.java fails with InvalidPathException on windows
  • 3f0da35: 8261392: Exclude testlibrary_tests/ctw/JarDirTest.java
  • 8d0faaf: 8257001: Improve Http Client Support
  • 9bf055d: 8259633: compiler/graalunit/CoreTest.java fails with NPE after JDK-8244543
  • ddc56d1: 8259428: AlgorithmId.getEncodedParams() should return copy
  • ae33d2a: 8258247: Couple of issues in fix for JDK-8249906
  • 2003e91: 8244543: Enhanced handling of abstract classes
  • e56e087: 8250568: Less ambiguous processing
  • ... and 170 more: https://git.openjdk.java.net/jdk/compare/b3782ead36022ecc3ee2375f0f2be15ca4bbeec6...master

Your commit was automatically rebased without conflicts.

Pushed as commit a22ad03.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8264983 branch April 20, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants