New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8264983: Add gtest for JDK-8264008 #3414
Conversation
/test |
👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into |
@DamonFool |
@DamonFool The |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Sorry for the long delay.
..Thomas
@@ -73,3 +73,18 @@ TEST_VM(MetaspaceUtils, committed_compressed_class_pointers) { | |||
EXPECT_LE(committed_class, committed); | |||
} | |||
|
|||
TEST_VM(MetaspaceUtils, none_compressed_class_pointers) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"non_compressed"
@DamonFool This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 162 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks @tstuefe for your review. |
/integrate |
@DamonFool Since your change was applied there have been 180 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit a22ad03. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
Here is the gtest for JDK-8264008 as discussed here: #3142 (review) .
Any comments?
Testing:
Thanks.
Best regards,
Jie
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3414/head:pull/3414
$ git checkout pull/3414
Update a local copy of the PR:
$ git checkout pull/3414
$ git pull https://git.openjdk.java.net/jdk pull/3414/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3414
View PR using the GUI difftool:
$ git pr show -t 3414
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3414.diff