8264997: Remove SystemDictionary::cache_get

[coleenp]

This is a trivial change to remove an unneeded function in SystemDictionary. The pd_cache_table() that is owned by SystemDictionary is already available to callers of SystemDictionary, ie. the ServiceThread, so there's no need to hide access inside of a function with a backwards name.

I also fixed add_protection_domain logging to be useful and fixed an assert.

Tested with mach5 tier1-3 in progress and manually.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8264997: Remove SystemDictionary::cache_get

Reviewers

• Harold Seigel (@hseigel - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3418/head:pull/3418
$ git checkout pull/3418

Update a local copy of the PR:
$ git checkout pull/3418
$ git pull https://git.openjdk.java.net/jdk pull/3418/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3418

View PR using the GUI difftool:
$ git pr show -t 3418

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3418.diff

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7900de31)
• 00: Full (9a661354)

[hseigel]

These changes look good and trivial.
Thanks, Harold

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264997: Remove SystemDictionary::cache_get

Reviewed-by: hseigel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 9ebc497: 8264765: BreakIterator sees bogus sentence boundary in parenthesized “i.e.” phrase
• ec31b3a: 8264727: Shenandoah: Remove extraneous whitespace from phase timings report

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Thanks Harold!
/integrate

[openjdk]

@coleenp Since your change was applied there have been 2 commits pushed to the master branch:

• 9ebc497: 8264765: BreakIterator sees bogus sentence boundary in parenthesized “i.e.” phrase
• ec31b3a: 8264727: Shenandoah: Remove extraneous whitespace from phase timings report

Your commit was automatically rebased without conflicts.

Pushed as commit f26cd2a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.