Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265319: implement Sealed Classes as a standard feature in Java, javax.lang.model changes #3528

Closed

Conversation

vicente-romero-oracle
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Apr 16, 2021

Please review the changes needed in javax.lang.model API to make Sealed Classes a final feature in Java. Please also review the related CSR

Thanks,

note: this PR is related to PR-3526


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265319: implement Sealed Classes as a standard feature in Java, javax.lang.model changes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3528/head:pull/3528
$ git checkout pull/3528

Update a local copy of the PR:
$ git checkout pull/3528
$ git pull https://git.openjdk.java.net/jdk pull/3528/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3528

View PR using the GUI difftool:
$ git pr show -t 3528

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3528.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 16, 2021

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@vicente-romero-oracle
Copy link
Contributor Author

/csr

@openjdk openjdk bot added rfr Pull request is ready for review csr Pull request needs approved CSR before integration labels Apr 16, 2021
@openjdk
Copy link

openjdk bot commented Apr 16, 2021

@vicente-romero-oracle this pull request will not be integrated until the CSR request JDK-8265320 for issue JDK-8265319 has been approved.

@openjdk
Copy link

openjdk bot commented Apr 16, 2021

@vicente-romero-oracle The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Apr 16, 2021

Webrevs

Copy link
Member

@jddarcy jddarcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

Seems that the associated test updates are being done under the related PR.

@vicente-romero-oracle
Copy link
Contributor Author

Looks fine.

Seems that the associated test updates are being done under the related PR.

thanks, correct they are in the related PR

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Apr 16, 2021
@openjdk
Copy link

openjdk bot commented Apr 16, 2021

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265319: implement Sealed Classes as a standard feature in Java, javax.lang.model changes

Reviewed-by: darcy, jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 16, 2021
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@vicente-romero-oracle
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this May 20, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 20, 2021
@openjdk
Copy link

openjdk bot commented May 20, 2021

@vicente-romero-oracle Since your change was applied there have been 2 commits pushed to the master branch:

  • 726785b: 8267155: runtime/os/TestTracePageSizes times out
  • 8e3549f: 8266332: Adler32 intrinsic for x86 64-bit platforms

Your commit was automatically rebased without conflicts.

Pushed as commit 31b98e1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants