Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262908: JFR: Allow JFR to stream events from a known repository path #3685

Closed
wants to merge 3 commits into from

Conversation

@egahlin
Copy link
Member

@egahlin egahlin commented Apr 26, 2021

Hi,

Could I have a review that makes it possible to use event streaming against the repository specified on command line (-XX:FlightRecorder:repository=directory)

This is useful if you want start JFR from a script and pass the directory to a monitoring process. Previously you had to use attach and read the directory from a system property.

Testing: jdk/jdk/jfr

Thanks
Erik


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8262908: JFR: Allow JFR to stream events from a known repository path

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3685/head:pull/3685
$ git checkout pull/3685

Update a local copy of the PR:
$ git checkout pull/3685
$ git pull https://git.openjdk.java.net/jdk pull/3685/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3685

View PR using the GUI difftool:
$ git pr show -t 3685

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3685.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 26, 2021

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-jfr label Apr 26, 2021
@egahlin egahlin marked this pull request as ready for review Apr 26, 2021
@openjdk openjdk bot added the rfr label Apr 26, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 26, 2021

Webrevs

Loading

Copy link

@mgronlun mgronlun left a comment

Looks good. Thank you.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 27, 2021

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262908: JFR: Allow JFR to stream events from a known repository path

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 161 new commits pushed to the master branch:

  • 377b346: 8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M
  • dc323a9: 8263421: Module image file is opened twice during VM startup
  • fbfd4ea: 8265914: Duplicated NotANode and not_a_node
  • 9481fad: 8163367: Test javax/swing/JComboBox/8033069/bug8033069NoScrollBar.java javax/swing/JComboBox/8033069/bug8033069ScrollBar.java fails intermittently
  • 9adbf15: 8265995: Shenandoah: Move ShenandoahInitMarkRootsClosure close to its use
  • 879a77f: 8265757: stack-use-after-scope in perfMemory_posix.cpp get_user_name_slow()
  • e4be968: 8265980: Fix systemDictionary and loaderConstraints printing
  • f6e26f6: 8265756: AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter
  • 0a4c338: 8263432: javac may report an invalid package/class clash on case insensitive filesystems
  • 82b3719: 8265967: Unused NullCheckNode forward declaration in node.hpp
  • ... and 151 more: https://git.openjdk.java.net/jdk/compare/fa58aae8f6b31e81f1e7c41af1b9343b1d70c5af...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Apr 27, 2021
@egahlin
Copy link
Member Author

@egahlin egahlin commented Apr 28, 2021

/integrate

Loading

@openjdk openjdk bot closed this Apr 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@egahlin Since your change was applied there have been 172 commits pushed to the master branch:

  • 30b1354: 8266153: mark hotspot compiler/onSpinWait tests which ignore VM flags
  • eeddb30: 8266150: mark hotspot compiler/arguments tests which ignore VM flags
  • feb18d2: 8266149: mark hotspot compiler/startup tests which ignore VM flags
  • eb72950: 8266154: mark hotspot compiler/oracle tests which ignore VM flags
  • 7f4a9f6: 8266088: compiler/arguments/TestPrintOptoAssemblyLineNumbers test should user driver mode
  • f560b89: 8264873: Dependencies: Split ClassHierarchyWalker
  • 0a88f0a: 8255915: jdk/incubator/vector/AddTest.java timed out
  • ab2aec2: 8265938: C2's conditional move optimization does not handle top Phi
  • 5634f20: 8265932: Move safepoint related fields from class Thread to JavaThread
  • b67b2b1: 8265690: Use the latest Ubuntu base image version in Docker testing
  • ... and 162 more: https://git.openjdk.java.net/jdk/compare/fa58aae8f6b31e81f1e7c41af1b9343b1d70c5af...master

Your commit was automatically rebased without conflicts.

Pushed as commit e144104.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants