-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8265773: incorrect jdeps message "jdk8internals" to describe a removed JDK internal API #3741
Conversation
…K API is incorrect
👋 Welcome back mchung! A progress list of the required criteria for merging this PR into |
/label remove compiler |
@mlchung |
@mlchung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 21 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@mlchung Since your change was applied there have been 32 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit b3b2bb2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
jdeps should print "JDK removed internal APIs" to give an informative description when a JDK internal API that is being referenced has been removed. JDK-8213909 incorrectly changed it to print
jdk8internals
.An example output is:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3741/head:pull/3741
$ git checkout pull/3741
Update a local copy of the PR:
$ git checkout pull/3741
$ git pull https://git.openjdk.java.net/jdk pull/3741/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3741
View PR using the GUI difftool:
$ git pr show -t 3741
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3741.diff