Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264472: Add a test group for running CDS tests with -XX:+VerifySharedSpaces #3771

Closed

Conversation

@calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented Apr 28, 2021

Add a new test group hotspot_cds_verify_shared_spaces for running some CDS tests with the -XX:+VerifySharedSpaces option.

Testing: hs-tier4.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264472: Add a test group for running CDS tests with -XX:+VerifySharedSpaces

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3771/head:pull/3771
$ git checkout pull/3771

Update a local copy of the PR:
$ git checkout pull/3771
$ git pull https://git.openjdk.java.net/jdk pull/3771/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3771

View PR using the GUI difftool:
$ git pr show -t 3771

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3771.diff

@calvinccheung
Copy link
Member Author

@calvinccheung calvinccheung commented Apr 28, 2021

/label add hotspot-runtime

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 28, 2021

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@calvinccheung
The hotspot-runtime label was successfully added.

@calvinccheung calvinccheung marked this pull request as ready for review Apr 28, 2021
@openjdk openjdk bot added the rfr label Apr 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 28, 2021

Webrevs

@iklam
iklam approved these changes Apr 28, 2021
Copy link
Member

@iklam iklam left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264472: Add a test group for running CDS tests with -XX:+VerifySharedSpaces

Reviewed-by: iklam, mseledtsov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 100 new commits pushed to the master branch:

  • b3b2bb2: 8265773: incorrect jdeps message "jdk8internals" to describe a removed JDK internal API
  • 2780577: 8196415: Disable SHA-1 Signed JARs
  • 21f65f8: 8266206: Build failure after JDK-8264752 with older GCCs
  • c71c268: 8266165: TestNoWarningLoopStripMiningIterSet is runnable only on VM w/ G1, Shenandoah, Z and Epsilon
  • 8954bef: 8266188: mark hotspot compiler/cpuflags tests which ignore VM flags
  • 19d3c45: 8266184: a few compiler/debug tests don't check exit code
  • 7e3bc4c: 8228442: DHKeyExchange/LegacyDHEKeyExchange.java failed due to "SSLException: An established connection was aborted by the software in your host machine"
  • f40bf1d: 8266087: Move 'buffer' declaration in get_user_name_slow() inside of linux specific code
  • ec383ab: 8183374: Refactor java/lang/Runtime shell tests to java
  • 343a4a7: 8185127: Add tests to cover hashCode() method for java supported crypto key types
  • ... and 90 more: https://git.openjdk.java.net/jdk/compare/8e312297d806f581c7a069af6c2ee2d8381b46b6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 28, 2021
Copy link
Member

@mseledts mseledts left a comment

Good idea. Changes look good to me.

@calvinccheung
Copy link
Member Author

@calvinccheung calvinccheung commented Apr 28, 2021

@iklam, @mseledts, Thanks for the quick review.

@calvinccheung
Copy link
Member Author

@calvinccheung calvinccheung commented Apr 28, 2021

/integrate

@openjdk openjdk bot closed this Apr 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@calvinccheung Since your change was applied there have been 100 commits pushed to the master branch:

  • b3b2bb2: 8265773: incorrect jdeps message "jdk8internals" to describe a removed JDK internal API
  • 2780577: 8196415: Disable SHA-1 Signed JARs
  • 21f65f8: 8266206: Build failure after JDK-8264752 with older GCCs
  • c71c268: 8266165: TestNoWarningLoopStripMiningIterSet is runnable only on VM w/ G1, Shenandoah, Z and Epsilon
  • 8954bef: 8266188: mark hotspot compiler/cpuflags tests which ignore VM flags
  • 19d3c45: 8266184: a few compiler/debug tests don't check exit code
  • 7e3bc4c: 8228442: DHKeyExchange/LegacyDHEKeyExchange.java failed due to "SSLException: An established connection was aborted by the software in your host machine"
  • f40bf1d: 8266087: Move 'buffer' declaration in get_user_name_slow() inside of linux specific code
  • ec383ab: 8183374: Refactor java/lang/Runtime shell tests to java
  • 343a4a7: 8185127: Add tests to cover hashCode() method for java supported crypto key types
  • ... and 90 more: https://git.openjdk.java.net/jdk/compare/8e312297d806f581c7a069af6c2ee2d8381b46b6...master

Your commit was automatically rebased without conflicts.

Pushed as commit d12e01a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@calvinccheung calvinccheung deleted the calvinccheung:8264472-new-test-group branch Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants