-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8266288: assert root method not found in witnessed_reabstraction_in_supers is too strong #3793
Conversation
👋 Welcome back jcm! A progress list of the required criteria for merging this PR into |
|
@jamsheedcm The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@jamsheedcm This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thank you for the reviews, Vladimir, Tobias. |
@jamsheedcm Since your change was applied there have been 28 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 49d0458. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
removing the assert as it is strong for miranda root_m.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3793/head:pull/3793
$ git checkout pull/3793
Update a local copy of the PR:
$ git checkout pull/3793
$ git pull https://git.openjdk.java.net/jdk pull/3793/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3793
View PR using the GUI difftool:
$ git pr show -t 3793
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3793.diff