8265984: Concurrent GC: Some tests fail "assert(is_frame_safe(f)) failed: Frame must be safe"

[pliden]

JDK-8265702 introduced a change in OptoRuntime::handle_exception_C() where it no longer processed frames when asking for the caller. This change turned out to cause intermittent test failures. We shouldn't have to process frames here, since we're not touching any oops, but it seems that processing frames here avoids some other issue. To avoid noise in out testing I suggest we revert to processing frames here for now (and add the required ThreadWXEnable for macos/aarch64), while we continue to investigate why this is needed.

Testing: Passed tier1-7 on linux/x86 and macos/aarch64

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8265984: Concurrent GC: Some tests fail "assert(is_frame_safe(f)) failed: Frame must be safe"

Reviewers

• Erik Österlund (@fisk - Reviewer)
• Stefan Karlsson (@stefank - Reviewer)
• Zhengyu Gu (@zhengyu123 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3814/head:pull/3814
$ git checkout pull/3814

Update a local copy of the PR:
$ git checkout pull/3814
$ git pull https://git.openjdk.java.net/jdk pull/3814/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3814

View PR using the GUI difftool:
$ git pr show -t 3814

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3814.diff

[bridgekeeper]

👋 Welcome back pliden! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[pliden]

/cc hotspot-gc

[openjdk]

@pliden
The hotspot-gc label was successfully added.

[mlbridge]

Webrevs

• 00: Full (75d67a7c)

[zhengyu123]

Should you add MACOS_AARCH64_ONLY(ThreadWXEnable wx(WXWrite, current)); here, as you suggested in CR?
Seems the code change is inconsistent with the comments above.

[pliden]

I reverted back to exactly what we used to do here prior to JDK-8265702, to avoid affecting anything but ZGC. I'm placing the ThreadWXEnable in the ZGC nmethod barrier since we want these as close to the patching code as possible, and we can end up in there through multiple paths.

[zhengyu123]

I see. Thanks.

[fisk]

Looks good.

[openjdk]

@pliden This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265984: Concurrent GC: Some tests fail "assert(is_frame_safe(f)) failed: Frame must be safe"

Reviewed-by: eosterlund, stefank, zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• 80941f4: 8234446: Post-CMS workgroup hierarchy cleanup
• ac760c7: 8266295: Remove unused _concurrent_iteration_safe_limit
• b42d496: 8266388: C2: Improve constant ShiftCntV on x86
• 05cfac9: 8266412: Remove redundant TemplateInterpreter entries
• c5dc657: 8266056: runtime/stringtable/StringTableCleaningTest.java failed with "RuntimeException: Missing Callback in [10, 11]"
• 8fa50eb: 8263363: Minor cleanup of Lanai code - unused code removal and comments correction
• 7e30130: 8266401: mark hotspot compiler/intrinsics/sha/cli tests which ignore VM flags
• dedddd5: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5
• 5c083e8: 8266129: tools/jpackage/windows/WinInstallerIconTest.java hangs with fastdebug
• 3e667cc: 8265356: need code example for getting canonical constructor of a Record
• ... and 10 more: https://git.openjdk.java.net/jdk/compare/07ecd421d1538ae53ffbea65eccfa938e19a9f0f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[pliden]

Thanks all for reviewing!

/integrate

[openjdk]

@pliden Since your change was applied there have been 21 commits pushed to the master branch:

• 1d9ea3a: 8266083: Shenandoah: Consolidate dedup/no dedup oop closures
• 80941f4: 8234446: Post-CMS workgroup hierarchy cleanup
• ac760c7: 8266295: Remove unused _concurrent_iteration_safe_limit
• b42d496: 8266388: C2: Improve constant ShiftCntV on x86
• 05cfac9: 8266412: Remove redundant TemplateInterpreter entries
• c5dc657: 8266056: runtime/stringtable/StringTableCleaningTest.java failed with "RuntimeException: Missing Callback in [10, 11]"
• 8fa50eb: 8263363: Minor cleanup of Lanai code - unused code removal and comments correction
• 7e30130: 8266401: mark hotspot compiler/intrinsics/sha/cli tests which ignore VM flags
• dedddd5: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5
• 5c083e8: 8266129: tools/jpackage/windows/WinInstallerIconTest.java hangs with fastdebug
• ... and 11 more: https://git.openjdk.java.net/jdk/compare/07ecd421d1538ae53ffbea65eccfa938e19a9f0f...master

Your commit was automatically rebased without conflicts.

Pushed as commit 194bcec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.