-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8266937: Remove Compile::reshape_address #3988
Conversation
👋 Welcome back redestad! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trivial.
@cl4es This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Yep. Thanks for reviewing! /integrate |
@cl4es Since your change was applied there have been 14 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 616244f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This method was introduced for aarch64 only in JDK-8154826 but the implementation was intentionally removed by JDK-8204348
The declarations and empty methods were left behind on all platforms, though.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3988/head:pull/3988
$ git checkout pull/3988
Update a local copy of the PR:
$ git checkout pull/3988
$ git pull https://git.openjdk.java.net/jdk pull/3988/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3988
View PR using the GUI difftool:
$ git pr show -t 3988
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3988.diff