-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8267212: test/jdk/java/util/Collections/FindSubList.java intermittent crash with "no reachable node should have no use" #4055
Conversation
… crash with "no reachable node should have no use"
👋 Welcome back hshi! A progress list of the required criteria for merging this PR into |
@huishi-hs The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
pre-submit tests have been passed https://github.com/huishi-hs/jdk/actions/runs/849445331 checking here still not completed. ignore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@huishi-hs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 23 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rwestrel, @TobiHartmann) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too.
Thanks @TobiHartmann @rwestrel ! |
/integrate |
@huishi-hs |
/sponsor |
@DamonFool @huishi-hs Since your change was applied there have been 32 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 324defe. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
… crash with "no reachable node should have no use"
Please help reivew this fix.
StrIntrinsicNode::Ideal uses Node::set_req to replace memory input, old memory input might have 0 use, but not added into PhaseGVN worklist. Using set_req_X to ensure add 0 out old memory input node into PhaseGVN worklist.
Find other two similar problemtic code in LoadNode::Ideal.
Tier1/2/3 pass with release/fastdebug build.
test/jdk/java/util/Collections/FindSubList.java doesn't fail in 100 runs (before fix 2/3 failure in 10 runs).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4055/head:pull/4055
$ git checkout pull/4055
Update a local copy of the PR:
$ git checkout pull/4055
$ git pull https://git.openjdk.java.net/jdk pull/4055/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4055
View PR using the GUI difftool:
$ git pr show -t 4055
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4055.diff