Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267212: test/jdk/java/util/Collections/FindSubList.java intermittent crash with "no reachable node should have no use" #4055

Closed
wants to merge 1 commit into from

Conversation

huishi-hs
Copy link

@huishi-hs huishi-hs commented May 17, 2021

… crash with "no reachable node should have no use"

Please help reivew this fix.

StrIntrinsicNode::Ideal uses Node::set_req to replace memory input, old memory input might have 0 use, but not added into PhaseGVN worklist. Using set_req_X to ensure add 0 out old memory input node into PhaseGVN worklist.

Find other two similar problemtic code in LoadNode::Ideal.

Tier1/2/3 pass with release/fastdebug build.
test/jdk/java/util/Collections/FindSubList.java doesn't fail in 100 runs (before fix 2/3 failure in 10 runs).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267212: test/jdk/java/util/Collections/FindSubList.java intermittent crash with "no reachable node should have no use"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4055/head:pull/4055
$ git checkout pull/4055

Update a local copy of the PR:
$ git checkout pull/4055
$ git pull https://git.openjdk.java.net/jdk pull/4055/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4055

View PR using the GUI difftool:
$ git pr show -t 4055

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4055.diff

… crash with "no reachable node should have no use"
@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2021

👋 Welcome back hshi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 17, 2021
@openjdk
Copy link

openjdk bot commented May 17, 2021

@huishi-hs The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label May 17, 2021
@mlbridge
Copy link

mlbridge bot commented May 17, 2021

Webrevs

@huishi-hs huishi-hs changed the title 8267212: test/jdk/java/util/Collections/FindSubList.java debug build intermittent crash with "no reachable node should have no use" 8267212: test/jdk/java/util/Collections/FindSubList.java intermittent crash with "no reachable node should have no use" May 17, 2021
@huishi-hs
Copy link
Author

pre-submit tests have been passed https://github.com/huishi-hs/jdk/actions/runs/849445331

checking here still not completed. ignore.

Copy link
Contributor

@rwestrel rwestrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented May 18, 2021

@huishi-hs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267212: test/jdk/java/util/Collections/FindSubList.java intermittent crash with "no reachable node should have no use"

Reviewed-by: roland, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • 894547d: 8266897: com/sun/net/httpserver/FilterTest.java fails intermittently with AssertionError
  • da7c846: 8264408: test_oopStorage no longer needs to disable some tests on WIN32
  • f6c2891: 8267229: Split runtime/Metaspace/elastic test configurations for better scalability
  • b60975d: 8267237: ARM32: bad AD file in matcher.cpp after 8266810
  • 905b41a: 8265711: C1: Intrinsify Class.getModifier method
  • 554caf3: 8251392: Consolidate Metaspace Statistics
  • 3e97b07: 8267116: Lanai: Incorrect AlphaComposite for VolatileImage graphics
  • cd1c17c: 8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report
  • 2effdd1: 8267112: JVMCI compiler modules should be kept upgradable
  • da4dfde: 8264777: Overload optimized FileInputStream::readAllBytes
  • ... and 13 more: https://git.openjdk.java.net/jdk/compare/f4227879b0504bc4656bd84153b13b04c007aa66...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rwestrel, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 18, 2021
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too.

@huishi-hs
Copy link
Author

Thanks @TobiHartmann @rwestrel !

@huishi-hs
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 18, 2021
@openjdk
Copy link

openjdk bot commented May 18, 2021

@huishi-hs
Your change (at version ef8a859) is now ready to be sponsored by a Committer.

@DamonFool
Copy link
Member

/sponsor

@openjdk openjdk bot closed this May 19, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 19, 2021
@openjdk
Copy link

openjdk bot commented May 19, 2021

@DamonFool @huishi-hs Since your change was applied there have been 32 commits pushed to the master branch:

  • bdbe23b: 8265462: Handle multiple slots in the NSS Internal Module from SunPKCS11's Secmod
  • 10236e7: 8263242: serviceability/sa/ClhsdbFindPC.java cannot find MaxJNILocalCapacity with ASLR
  • e6705c0: 8266949: Check possibility to disable OperationTimedOut on Unix
  • b92c5a4: 8265292: [macos_aarch64] java/foreign/TestDowncall.java crashes with SIGBUS
  • fadf580: 8262952: [macos_aarch64] os::commit_memory failure
  • f8f40ab: 8230486: G1BarrierSetAssembler::g1_write_barrier_post unnecessarily pushes/pops new_val
  • 9d168e2: 8266973: Migrate to ClassHierarchyIterator when enumerating subclasses
  • 02507bc: 8267166: Remove test file vmTestbase/vm/mlvm/tools/LoadClass.java
  • ce88b33: 8266615: C2 incorrectly folds subtype checks involving an interface array
  • 894547d: 8266897: com/sun/net/httpserver/FilterTest.java fails intermittently with AssertionError
  • ... and 22 more: https://git.openjdk.java.net/jdk/compare/f4227879b0504bc4656bd84153b13b04c007aa66...master

Your commit was automatically rebased without conflicts.

Pushed as commit 324defe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@huishi-hs huishi-hs deleted the 8267212 branch June 4, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
4 participants