-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8261478: InstanceKlass::set_classpath_index does not match comments #4170
8261478: InstanceKlass::set_classpath_index does not match comments #4170
Conversation
/label add hotspot-runtime |
👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into |
@calvinccheung |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is a leftover of JDK-8240204.
@calvinccheung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks @yminqi. Since this is a comment only change, I'll integrate now. |
@calvinccheung Since your change was applied there have been 6 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 461a3fe. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
A simple patch for updating the comment for the
InstanceKlass::set_classpath_index()
function.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4170/head:pull/4170
$ git checkout pull/4170
Update a local copy of the PR:
$ git checkout pull/4170
$ git pull https://git.openjdk.java.net/jdk pull/4170/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4170
View PR using the GUI difftool:
$ git pr show -t 4170
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4170.diff