Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261478: InstanceKlass::set_classpath_index does not match comments #4170

Conversation

@calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented May 24, 2021

A simple patch for updating the comment for the InstanceKlass::set_classpath_index() function.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261478: InstanceKlass::set_classpath_index does not match comments

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4170/head:pull/4170
$ git checkout pull/4170

Update a local copy of the PR:
$ git checkout pull/4170
$ git pull https://git.openjdk.java.net/jdk pull/4170/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4170

View PR using the GUI difftool:
$ git pr show -t 4170

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4170.diff

@calvinccheung
Copy link
Member Author

@calvinccheung calvinccheung commented May 24, 2021

/label add hotspot-runtime

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 24, 2021

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 24, 2021

@calvinccheung
The hotspot-runtime label was successfully added.

Loading

@calvinccheung calvinccheung marked this pull request as ready for review May 24, 2021
@openjdk openjdk bot added the rfr label May 24, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 24, 2021

Webrevs

Loading

yminqi
yminqi approved these changes May 24, 2021
Copy link
Contributor

@yminqi yminqi left a comment

LGTM. This is a leftover of JDK-8240204.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 24, 2021

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261478: InstanceKlass::set_classpath_index does not match comments

Reviewed-by: minqi

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • c519ba2: 8267614: Outline VarHandleGuards exact behavior checks
  • f690959: 8267446: Taskqueue code fails with assert(bottom_relaxed() == age_top_relaxed()) failed: not empty
  • ebc9357: 8267329: Modernize Javadoc code to use instanceof with pattern matching
  • 209769b: 8267347: CDS record_linking_constraint asserts with unregistered class
  • a5467ae: 8267423: Fix copyrights in jpackage tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label May 24, 2021
@calvinccheung
Copy link
Member Author

@calvinccheung calvinccheung commented May 25, 2021

Thanks @yminqi. Since this is a comment only change, I'll integrate now.
/integrate

Loading

@openjdk openjdk bot closed this May 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 25, 2021

@calvinccheung Since your change was applied there have been 6 commits pushed to the master branch:

  • de27da7: 8267431: Rename InstanceKlass::has_old_class_version to can_be_verified_at_dumptime
  • c519ba2: 8267614: Outline VarHandleGuards exact behavior checks
  • f690959: 8267446: Taskqueue code fails with assert(bottom_relaxed() == age_top_relaxed()) failed: not empty
  • ebc9357: 8267329: Modernize Javadoc code to use instanceof with pattern matching
  • 209769b: 8267347: CDS record_linking_constraint asserts with unregistered class
  • a5467ae: 8267423: Fix copyrights in jpackage tests

Your commit was automatically rebased without conflicts.

Pushed as commit 461a3fe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@calvinccheung calvinccheung deleted the 8261478-set_classpath_index-comment branch May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants