Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268146: fix for JDK-8266254 fails validate-source #4323

Closed
wants to merge 1 commit into from

Conversation

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jun 2, 2021

A trivial copyright fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268146: fix for JDK-8266254 fails validate-source

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4323/head:pull/4323
$ git checkout pull/4323

Update a local copy of the PR:
$ git checkout pull/4323
$ git pull https://git.openjdk.java.net/jdk pull/4323/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4323

View PR using the GUI difftool:
$ git pr show -t 4323

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4323.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 2, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jun 2, 2021

/label add hotspot-runtime

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Jun 2, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jun 2, 2021

/label add core-libs

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jun 2, 2021

@PaulSandoz - Thanks for the fast review!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268146: fix for JDK-8266254 fails validate-source

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 136badb: 8248268: Support KWP in addition to KW

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the core-libs label Jun 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2021

@dcubed-ojdk
The core-libs label was successfully added.

Copy link
Contributor

@bradfordwetmore bradfordwetmore left a comment

LGTM

@openjdk openjdk bot closed this Jun 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2021

@dcubed-ojdk Since your change was applied there has been 1 commit pushed to the master branch:

  • 136badb: 8248268: Support KWP in addition to KW

Your commit was automatically rebased without conflicts.

Pushed as commit 76fdf2c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8268146 branch Jun 2, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 2, 2021

Webrevs

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jun 2, 2021

@bradfordwetmore - Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants