Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8268147: need to update reference to testng module for jtreg6 #4325

Closed

Conversation

@jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Jun 2, 2021

Please review a test fix to refer to the new name of the TestNG module.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268147: need to update reference to testng module for jtreg6

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4325/head:pull/4325
$ git checkout pull/4325

Update a local copy of the PR:
$ git checkout pull/4325
$ git pull https://git.openjdk.java.net/jdk pull/4325/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4325

View PR using the GUI difftool:
$ git pr show -t 4325

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4325.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 2, 2021

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2021

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Jun 2, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 2, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Looks good and trivial.

Thanks,
David

naotoj
naotoj approved these changes Jun 2, 2021
@jonathan-gibbons
Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons commented Jun 2, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2021

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268147: need to update reference to testng module for jtreg6

Reviewed-by: dholmes, psandoz, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 2, 2021
@openjdk openjdk bot closed this Jun 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2021

@jonathan-gibbons Pushed as commit d46a2c8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jonathan-gibbons jonathan-gibbons deleted the 8268147.testng branch Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants