New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8268147: need to update reference to testng module for jtreg6 #4325
Conversation
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
@jonathan-gibbons The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial.
Thanks,
David
/integrate |
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@jonathan-gibbons Pushed as commit d46a2c8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review a test fix to refer to the new name of the TestNG module.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4325/head:pull/4325
$ git checkout pull/4325
Update a local copy of the PR:
$ git checkout pull/4325
$ git pull https://git.openjdk.java.net/jdk pull/4325/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4325
View PR using the GUI difftool:
$ git pr show -t 4325
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4325.diff