Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8268018: remove dead code in commitLimitter #4329

Closed

Conversation

@Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Jun 3, 2021

it's trivial cleanup to remove some dead code.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4329/head:pull/4329
$ git checkout pull/4329

Update a local copy of the PR:
$ git checkout pull/4329
$ git pull https://git.openjdk.java.net/jdk pull/4329/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4329

View PR using the GUI difftool:
$ git pr show -t 4329

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4329.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 3, 2021

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jun 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 3, 2021

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 3, 2021

Webrevs

Loading

@navyxliu
Copy link
Contributor

@navyxliu navyxliu commented Jun 3, 2021

LGTM.

Loading

@Hamlin-Li
Copy link
Author

@Hamlin-Li Hamlin-Li commented Jun 7, 2021

ping~

Loading

Copy link
Contributor

@zhengyu123 zhengyu123 left a comment

Looks good and trivial

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 7, 2021

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268018: remove dead code in commitLimitter

Reviewed-by: zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 139 new commits pushed to the master branch:

  • e4d0454: 8267832: SimpleVisitors and Scanners in jdk.compiler should use @implSpec
  • 8130be5: 8268318: Missing comma in copyright header
  • b09d8b9: 8267926: AsyncLogGtest.java fails on assert with: decorator was not part of the decorator set specified at creation.
  • 5ebd419: 8267972: Inline cache cleaning is not monotonic
  • 6d1f3ac: 8149138: [javadoc] Fix SerialFormBuilder eliminate String bashing
  • 58bdabc: 8268164: Adopt cast notation for WorkerThread conversions
  • 9fc914b: 8204686: Dynamic parallel reference processing support for Parallel GC
  • 908aca2: 8262891: Compiler implementation for Pattern Matching for switch (Preview)
  • 3e48244: 8268301: Closed test: compiler/c2/6371167/Test.java fails after JDK-8267904
  • 204b492: 8267703: runtime/cds/appcds/cacheObject/HeapFragmentationTest.java crashed with OutOfMemory
  • ... and 129 more: https://git.openjdk.java.net/jdk/compare/1d2c7ac3f7492b335757bf0fd3f6ca3941c5fc72...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jun 7, 2021
@Hamlin-Li
Copy link
Author

@Hamlin-Li Hamlin-Li commented Jun 7, 2021

@zhengyu123 @navyxliu Thanks for your review.

Loading

@Hamlin-Li
Copy link
Author

@Hamlin-Li Hamlin-Li commented Jun 7, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jun 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 7, 2021

@Hamlin-Li Since your change was applied there have been 140 commits pushed to the master branch:

  • 15715a8: 8267924: Misleading G1 eager reclaim detail logging
  • e4d0454: 8267832: SimpleVisitors and Scanners in jdk.compiler should use @implSpec
  • 8130be5: 8268318: Missing comma in copyright header
  • b09d8b9: 8267926: AsyncLogGtest.java fails on assert with: decorator was not part of the decorator set specified at creation.
  • 5ebd419: 8267972: Inline cache cleaning is not monotonic
  • 6d1f3ac: 8149138: [javadoc] Fix SerialFormBuilder eliminate String bashing
  • 58bdabc: 8268164: Adopt cast notation for WorkerThread conversions
  • 9fc914b: 8204686: Dynamic parallel reference processing support for Parallel GC
  • 908aca2: 8262891: Compiler implementation for Pattern Matching for switch (Preview)
  • 3e48244: 8268301: Closed test: compiler/c2/6371167/Test.java fails after JDK-8267904
  • ... and 130 more: https://git.openjdk.java.net/jdk/compare/1d2c7ac3f7492b335757bf0fd3f6ca3941c5fc72...master

Your commit was automatically rebased without conflicts.

Pushed as commit 728a411.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@Hamlin-Li Hamlin-Li deleted the remove-dc-in-commitLimiter branch Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants