-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility #4412
Closed
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c05c814
8267385: Create NSAccessibilityElement implementation for JavaCompone…
savoptik 66ce693
8262031: Create implementation for NSAccessibilityNavigableStaticText…
savoptik f7979c6
8264287: Create implementation for NSAccessibilityComboBox protocol peer
savoptik e8b284f
8264303: Create implementation for NSAccessibilityTabGroup protocol peer
savoptik dd219ab
8264292: Create implementation for NSAccessibilityList protocol peer
savoptik d74af05
8267387: Create implementation for NSAccessibilityOutline protocol
savoptik 280ee5f
8267388: Create implementation for NSAccessibilityTable protocol
savoptik e9b966b
Even on Linux? I meant if the test will be run on the platform where …
savoptik ba09569
1. Fixed memory management problems, due to which a11y cells in table…
savoptik fbe3443
Why not mark them as @Native in the CAccessibility and use constants …
savoptik 76cba14
ok, so this is in the new code, how hard it will be to reimplement th…
savoptik b4ef57a
1. Removing the warning about an unaccessible element in the console.
savoptik a07c86d
Wildcard imports are avoided in new tests
savoptik 6505334
1. The comment states that it is not necessary to call ExceptionCheck…
savoptik a13d6a6
1. Fixed problems with vertical navigation in table cells;
savoptik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the a11y interface miss "setSelectedIndex" method? The code above will not work for the custom component which uses the "AccessibleJListChild" a11y object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, the current a11y interface does not allow this action.
As for the custom AccessibleJListChild, I prepared a sample project in which I implemented a custom child. The experiment showed that there are no negative consequences. The custom child works as intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the example, you use a JList class, and the checks in the code above works, but if some other "AccessibleJList" class will be used then it will not work, right? This is the reason why implementations of a11y classes usually use specific interfaces like "AccessibleJList".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this will not work with a custom list not inherited from JList. Unfortunately AccessibleJList is not perfect and the functionality you need is not there.
If you have a better solution, please share it. - Could you please advice on what we can do here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I meant in the first message, "a11y interface miss setSelectedIndex method". I suggest filing a separate issue to accumulate such use cases and then fix them by adding additional methods to a11y interfaces. Probably something similar will be found in the Table/etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. JDK-8271846