Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268353: Test libsvml.so is and is not present in jdk image #4421

Closed

Conversation

@PaulSandoz
Copy link
Member

@PaulSandoz PaulSandoz commented Jun 8, 2021

Test that when the jdk.incubator.vector module is present that libsvml.so is present, and test the opposite case.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268353: Test libsvml.so is and is not present in jdk image

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4421/head:pull/4421
$ git checkout pull/4421

Update a local copy of the PR:
$ git checkout pull/4421
$ git pull https://git.openjdk.java.net/jdk pull/4421/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4421

View PR using the GUI difftool:
$ git pr show -t 4421

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4421.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 8, 2021

👋 Welcome back psandoz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jun 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 8, 2021

@PaulSandoz The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 8, 2021

Webrevs

Loading

@PaulSandoz PaulSandoz closed this Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant