New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268475: execute runtime/InvocationTests w/ -UseVtableBasedCHA #4438
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
81 changes: 81 additions & 0 deletions
81
test/hotspot/jtreg/runtime/InvocationTests/invocationOldCHATests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
/* | ||
* Copyright (c) 2019, 2021, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
* | ||
*/ | ||
|
||
/* | ||
* @test | ||
* @summary Run invocation tests with old CHA (-XX:-UseVtableBasedCHA) | ||
* @library /test/lib | ||
* @modules java.base/jdk.internal.org.objectweb.asm | ||
* java.base/jdk.internal.misc | ||
* @compile shared/AbstractGenerator.java shared/AccessCheck.java shared/AccessType.java | ||
* shared/Caller.java shared/ExecutorGenerator.java shared/Utils.java | ||
* shared/ByteArrayClassLoader.java shared/Checker.java shared/GenericClassGenerator.java | ||
* @compile invokespecial/Checker.java invokespecial/ClassGenerator.java invokespecial/Generator.java | ||
* invokevirtual/Checker.java invokevirtual/ClassGenerator.java invokevirtual/Generator.java | ||
* invokeinterface/Checker.java invokeinterface/ClassGenerator.java invokeinterface/Generator.java | ||
* | ||
* @run driver/timeout=1800 invocationOldCHATests | ||
*/ | ||
|
||
import jdk.test.lib.process.ProcessTools; | ||
import jdk.test.lib.process.OutputAnalyzer; | ||
import jdk.test.lib.compiler.InMemoryJavaCompiler; | ||
|
||
public class invocationOldCHATests { | ||
|
||
public static void runTest(String whichTests, String classFileVersion) throws Throwable { | ||
System.out.println("\nOld CHA invocation tests, Tests: " + whichTests + | ||
", class file version: " + classFileVersion); | ||
ProcessBuilder pb = ProcessTools.createJavaProcessBuilder("-Xmx128M", | ||
"-Xcomp", "-XX:+UnlockDiagnosticVMOptions", "-XX:-UseVtableBasedCHA", | ||
"--add-exports", "java.base/jdk.internal.org.objectweb.asm=ALL-UNNAMED", | ||
whichTests, "--classfile_version=" + classFileVersion); | ||
OutputAnalyzer output = new OutputAnalyzer(pb.start()); | ||
try { | ||
output.shouldContain("EXECUTION STATUS: PASSED"); | ||
output.shouldHaveExitValue(0); | ||
} catch (Throwable e) { | ||
System.out.println( | ||
"\nNote that an entry such as 'B.m/C.m' in the failure chart means that" + | ||
" the test case failed because method B.m was invoked but the test " + | ||
"expected method C.m to be invoked. Similarly, a result such as 'AME/C.m'" + | ||
" means that an AbstractMethodError exception was thrown but the test" + | ||
" case expected method C.m to be invoked."); | ||
System.out.println( | ||
"\nAlso note that passing --dump to invoke*.Generator will" + | ||
" dump the generated classes (for debugging purposes).\n"); | ||
|
||
throw e; | ||
} | ||
} | ||
|
||
public static void main(String args[]) throws Throwable { | ||
// Get current major class file version and test with it. | ||
byte klassbuf[] = InMemoryJavaCompiler.compile("blah", "public class blah { }"); | ||
int major_version = klassbuf[6] << 8 | klassbuf[7]; | ||
runTest("invokespecial.Generator", String.valueOf(major_version)); | ||
runTest("invokeinterface.Generator", String.valueOf(major_version)); | ||
runTest("invokevirtual.Generator", String.valueOf(major_version)); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a new test, should this be just 2021, no 2019?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, this file (and the majority of its code) is based on the file which was originated in 2019, hence I believe it should be 2019.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Thanks for clarification.