Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268620: InfiniteLoopException test may fail on x86 platforms #4488

Closed
wants to merge 2 commits into from

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Jun 14, 2021

Small test update.

This test posts lots of events to EDT from the different threads, and it checks that the robot.waitForIdle() on the main thread will not hang or throw an exception. And this test fails on x86. The post of events are implemented via wait/notifyAll, and the robot.waitForIdle() is also implemented via wait/notifyAll on the same monitor, and on x86 platform, the wait() in the robot.waitForIdle() is never interrupted/notified by the notifyAll(), and it hangs forever.

I do not think this bug is specific to the x86(I tested 8u), it is just accidentally working fine on the mainline.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268620: InfiniteLoopException test may fail on x86 platforms

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4488/head:pull/4488
$ git checkout pull/4488

Update a local copy of the PR:
$ git checkout pull/4488
$ git pull https://git.openjdk.java.net/jdk pull/4488/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4488

View PR using the GUI difftool:
$ git pr show -t 4488

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4488.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 14, 2021

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 14, 2021

@mrserb The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Jun 14, 2021
@mrserb mrserb marked this pull request as ready for review Jun 14, 2021
@openjdk openjdk bot added the rfr label Jun 14, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 14, 2021

Webrevs

prrace
prrace approved these changes Jun 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 14, 2021

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268620: InfiniteLoopException test may fail on x86 platforms

Reviewed-by: prr, trebari, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • d384093: 8268125: ZGC: Clone oop array gets wrong acopy stub
  • 9f3c7e7: 8238649: Call new Win32 API SetThreadDescription in os::set_native_thread_name
  • 2e70bc3: 8268626: Remove native pre-jdk9 support for jtreg failure handler
  • e59acd9: 8268699: Shenandoah: Add test for JDK-8268127
  • 17295b1: Merge
  • b318535: 8267579: Thread::cooked_allocated_bytes() hits assert(left >= right) failed: avoid underflow
  • fe48ea9: 8268342: java/foreign/channels/TestAsyncSocketChannels.java fails with "IllegalStateException: This segment is already closed"
  • 6171ae4: 8268630: ProblemList serviceability/jvmti/CompiledMethodLoad/Zombie.java on linux-aarch64
  • 01054e6: 8268470: CDS dynamic dump asserts with JFR RecordingStream
  • e39346e: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/49112fa5752174a77fb5cd276fdd4240bf76bf82...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 14, 2021
@mrserb
Copy link
Member Author

@mrserb mrserb commented Jun 15, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

Going to push as commit 0b09129.
Since your change was applied there have been 26 commits pushed to the master branch:

  • d384093: 8268125: ZGC: Clone oop array gets wrong acopy stub
  • 9f3c7e7: 8238649: Call new Win32 API SetThreadDescription in os::set_native_thread_name
  • 2e70bc3: 8268626: Remove native pre-jdk9 support for jtreg failure handler
  • e59acd9: 8268699: Shenandoah: Add test for JDK-8268127
  • 17295b1: Merge
  • b318535: 8267579: Thread::cooked_allocated_bytes() hits assert(left >= right) failed: avoid underflow
  • fe48ea9: 8268342: java/foreign/channels/TestAsyncSocketChannels.java fails with "IllegalStateException: This segment is already closed"
  • 6171ae4: 8268630: ProblemList serviceability/jvmti/CompiledMethodLoad/Zombie.java on linux-aarch64
  • 01054e6: 8268470: CDS dynamic dump asserts with JFR RecordingStream
  • e39346e: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/49112fa5752174a77fb5cd276fdd4240bf76bf82...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@mrserb Pushed as commit 0b09129.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8268620 branch Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants